-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't detach completion popup while typing when prefix is empty #5517
Conversation
…osition when inline enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5517 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 588 588
Lines 42553 42576 +23
Branches 7071 7071
=======================================
+ Hits 36834 36858 +24
+ Misses 5719 5718 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Issue #, if available: NA
Description of changes: Currently, when auto showing completion during typing, the popup gets detached when the prefix is
""
. This can be problematic in situations when completions are coming in while typing sentences (e.g. when using AI code generation). When you pause after typing a space and a completion comes in from the completer, the popup will be detached because the prefix at that point in time is""
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: