Fix wrong values set for JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET ConfigMap key #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CONTAINER_IMAGE_PULL_SECRET Fixes a regression caused by #52034 When specifying the common values in `global.imagePullSecrets` and `global.jobs.kube.main_container_image_pull_secret`, the duplicate would cause the application to fail at runtime. Also, when not specifying any pull secrets, an empty string would be set for the value of the `JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET` configmap key, causing to end up as `null` in the configmap.
|
|
|
Thanks @jamezrin the team is working to get a fix for #52034 asap. |
|
/create-oss-pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a regression caused by 201b8e8 (causes issue: airbytehq/airbyte#52034)
When specifying common values in
global.imagePullSecretsandglobal.jobs.kube.main_container_image_pull_secret, the duplicates would cause the application to fail at runtime.Also, when not specifying any pull secrets (either via
global.imagePullSecretsorglobal.jobs.kube.main_container_image_pull_secret), an empty string would be set for the value of theJOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRETconfigmap key, causing to end up asnullin the configmap.How
uniqfunctionquotefunction. If the result of the concatenation of the list resolves to an empty string, this way the entry will still end up in the configmap. Otherwise, it will end up being interpreted asnulland will actually not be present in the configmap.Can this PR be safely reverted and rolled back?