-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm] Error on workload-launcher after migrating to 1.4.0 version #52034
Comments
Hi @dantonbertuol! What previous Airbyte version were you on prior to upgrading to 1.4? |
Hi. Version 1.3.1 |
@dantonbertuol Can you try removing We made a change that uses I tested this locally and it seemed to work for me. All the job pods still had the image pull secret. Let me know if that works, I hope I didn't miss anything. Thanks. |
Hello @abuchanan-airbyte, thanks for the answer. As I mentioned in the issue, removing the main_container_image_pull_secret property works. Even if I leave it out, if I apply global.imagePullSecrets, will it be used in the job containers? If that's the case, everything is fine, because removing it worked. |
Right. I expect that in 1.4.0 you should only need |
I checked the Airbyte configmap, and the So it should work. |
@marcosmarxm @abuchanan-airbyte I submitted a PR to airbyte-platform with a fix, please check airbytehq/airbyte-platform#383 |
The error only occurs in version 1.4.0. I have checked versions 1.2.0 and 1.3.2, but the issue does not arise in those versions. Error: couldn't find key JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET in ConfigMap airbyte/airbyte-airbyte-env |
I'm getting the same error. I have never set the image pull secret value in my helm values and no default is being set in the configmap, so the pod fails to start due to the missing key. I have manually removed the mapping from the deployment template for now. |
For some reason, I can't reproduce this problem. We can probably fix the charts to be more defensive, but I'm still curious where this is coming from. Can people share their |
Helm Chart Version
1.4.0
What step the error happened?
On deploy
Relevant information
I am facing an issue after upgrading to Airbyte version 1.4.0.
The problem occurs in the airbyte-workload-launcher pod and is an error when trying to create new pods, such as checking a data source. The problem that occurs is:
My values.yaml contains the configuration:
Note: removing the
main_container_image_pull_secret
property works, but it no longer uses the custom pullSecret, and I need to use it.Complete exception
Relevant log output
The text was updated successfully, but these errors were encountered: