chore(number-field): added default-value example to the doc site #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromenumber-field permalinkbasic-test
slider permalinktest-basic
Firefoxnumber-field permalinkbasic-test
slider permalinktest-basic
|
TarunAdobe
force-pushed
the
feat/number-field-default
branch
from
783b27c to
acb640e
Compare
TarunAdobe
changed the title
1 task
1 task
Pull Request Test Coverage Report for Build 10668435702Details
💛 - Coveralls |
blunteshwar
requested changes
Sep 2, 2024
Rajdeepc
requested changes
Sep 2, 2024
VRT's are good. I am adding a fix for the |
Rajdeepc
approved these changes
Sep 2, 2024
nikkimk
pushed a commit
that referenced
this pull request
Sep 13, 2024
* chore(number-field): added a default-value example in docs * chore: update number-field docs Co-authored-by: Rajdeep Chandra <[email protected]> --------- Co-authored-by: Rajdeep Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expand
number-fielddoc.Related issue(s)
Motivation and context
Currently, removing the number in the number field leaves the number field blank. It would be nice if the number field could repopulate to either the previous value, or the default value (ex. 0).
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.