Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: sp-number-field repopulate field after deletion #4109

Closed
1 task done
cdvu1 opened this issue Mar 1, 2024 · 2 comments · Fixed by #4698
Closed
1 task done

[Feat]: sp-number-field repopulate field after deletion #4109

cdvu1 opened this issue Mar 1, 2024 · 2 comments · Fixed by #4698
Assignees
Labels
enhancement New feature or request jira ticket created triage An issue needing triage

Comments

@cdvu1
Copy link
Collaborator

cdvu1 commented Mar 1, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-number-field

Description of the requested feature

Currently, removing the number in the number field leaves the number field blank. It would be nice if the number field could repopulate to either the previous value, or the default value (ex. 0).

Mockups or screenshots

No response

Implementation notes or ideas

No response

@cdvu1 cdvu1 added enhancement New feature or request triage An issue needing triage labels Mar 1, 2024
@Westbrook
Copy link
Contributor

0 and undefined are highly different values both in javascript as well as within the context of a working application. Where there to be a "default after deleting" how would you expect a user to inform the application that undefined was the correct value?

@TarunAdobe
Copy link
Contributor

Hello @cdvu1. I discussed the idea of having a default-value for the number-field component with the team. We felt that since the number-field component is a controllable by the consuming application, having a reset to default-valuebehaviour can be easily created by listening to the @change event on the number-field component. I have added an example of the same in our doc site in this PR. Let me know if this helps :)

@TarunAdobe TarunAdobe linked a pull request Aug 29, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira ticket created triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants