-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bxt_enable_big_map #500
Conversation
Requested changes in khanghugo#2 |
Delta PR corrections
And also, can you make this also optionally disabled? Toggle-like I think it will be cool to make custom bit flags and save them in BXT data for specific feature enabled, so you will know if the runner forgot to restart the game to disabling this option, that would be good idea too |
What do you mean by optionally disabled? The feature as a whole or the big map when I don't want to have big map anymore? The former I guess could be done if they have a cvar enable to have them enable this? LOL. As for the latter, it is just a lot more complicated. Like not complicated but cumbersome. Deep copy the struct then restore it back, something on the top of my head. I just guess that people running this command will just do stuffs in the big map and don't do anything else. The flag thing seems like a good choice though that is not really my domain and I definitely won't know how to test it. |
Requested in khanghugo#3 |
Store flags for some features enabled to BXT runtime data
{ | ||
auto &hw = HwDLL::GetInstance(); | ||
|
||
if (hw.g_sv_delta == NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also check for IsInWorld?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that make it not work until a server is started because the pointer is yet found? This big map works by changing deltas before starting the server. Delta (delta.lst) is loaded upon starting the game, not the server.
The IsInWorld
function is auxiliary compared to delta change, it is more for a select few entities to behave in big map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
i love github Co-authored-by: Ivan Molodetskikh <[email protected]>
i love github Co-authored-by: Ivan Molodetskikh <[email protected]>
Thanks |
Closes #499
Here is an apparent big map.
arte_marte (2).zip
(waiting for CI to test Windows build)