-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Migrate away from parts and only export the files we intend consumers to use #65
Merged
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f532d8a
Migrate away from parts and only export the files we intend consumers…
travissanderson-wf a71b387
Trick to get example app access to non-public root node
travissanderson-wf 83af46a
Enforce and fix all recommended lints
travissanderson-wf a45199e
More lints
travissanderson-wf 02e2ccf
Merge branch 'deprecations' into add-recommended-lints
travissanderson-wf c7baef2
Apply lints to new code
travissanderson-wf 42d21b7
Rewrite updateBoundingRect for readability
travissanderson-wf 69fcc49
Disable implicit casts
travissanderson-wf c7e21dd
Merge branch 'master' of github.com:Workiva/r_tree into control-publi…
travissanderson-wf d004538
Naive removal of deprecated methods
travissanderson-wf 11616ee
Apply recommended lints
travissanderson-wf b697b42
Remove unused dependency
travissanderson-wf 99e1392
Remove unnecessary this caught in Dart 2.18.7
travissanderson-wf fe704f8
Introduce an unnecessary this to test analyze
travissanderson-wf 975a1cc
Try a Dart 3 CI
travissanderson-wf 2d56f4c
Temporarily remove implicit rules
travissanderson-wf 9787fd1
Revert temporary changes
travissanderson-wf c6aac01
Localize concept of "margin"
travissanderson-wf e842cd2
Always return a List and update the return type accordingly
travissanderson-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
linter: | ||
rules: | ||
- cancel_subscriptions | ||
- close_sinks | ||
include: package:workiva_analysis_options/v2.recommended.yaml | ||
analyzer: | ||
strong-mode: | ||
implicit-casts: false | ||
implicit-dynamic: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now there's still a difference between doing add with one item vs many items, so we can probably keep the benchmarks around until we change that in a future PR.