BREAKING: Migrate away from parts and only export the files we intend consumers to use #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| print('Running benchmarks...'); | ||
| var collector = ScoreCollector(); | ||
| final collector = ScoreCollector(); | ||
| InsertBenchmark(collector, totalItems: 100).report(); | ||
| InsertBenchmark(collector, totalItems: 1000).report(); | ||
| InsertBenchmark(collector, totalItems: 10000).report(); |
There was a problem hiding this comment.
As of now there's still a difference between doing add with one item vs many items, so we can probably keep the benchmarks around until we change that in a future PR.
|
Sorry for the large diff. I wanted to make sure we had return types on all the things and decided to just merge my lints branch in, but if it is too much of a PITA I can redo it with just the return types. |
travissanderson-wf
changed the title
| } | ||
|
|
||
| return margin; | ||
| } | ||
|
|
||
| Node _boundingBoxForDistribution(Node<E> node, int startChild, int stopChild) { | ||
| final destNode = LeafNode(_branchFactor); | ||
| destNode._minimumBoundingRect = node.children[0].rect; |
There was a problem hiding this comment.
this was actually a bug, it should have been using startChild
danielway-wk
approved these changes
Nov 17, 2023
|
QA +1
|
kerbyseeley-wf
approved these changes
Nov 20, 2023
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a lot of excess public symbols that shouldn't be. We also prefer not to structure things using parts, and have a lot of code that doesn't match standard lints. This PR addresses all of those things, which will cause a need for a major release.