Update to the latest close_preopen.rs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the close_preopens test to the latest upstream version, which implements WebAssembly/WASI#522. Preopens may now be closed.
loganek
approved these changes
Mar 21, 2023
codefromthecrypt
pushed a commit
to tetratelabs/wazero
that referenced
this pull request
Mar 21, 2023
wasi-testsuite changed its mind. See WebAssembly/wasi-testsuite#66 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
added a commit
to tetratelabs/wazero
that referenced
this pull request
Mar 21, 2023
…kips interesting_paths (#1265) wasi-testsuite changed its mind on pre-open WebAssembly/wasi-testsuite#66 they also now explicitly forbid paths being passed in with a leading slash. Even when the config bug on WebAssembly/wasi-testsuite#67 is finished, this requires discussion if we want to EPERM on that. Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the close_preopens test to the latest upstream version, which implements WebAssembly/WASI#522. Preopens may now be closed.