wasi: removes constraint around closing a pre-open, and temporarily s…

…kips interesting_paths (#1265) wasi-testsuite changed its mind on pre-open WebAssembly/wasi-testsuite#66 they also now explicitly forbid paths being passed in with a leading slash. Even when the config bug on WebAssembly/wasi-testsuite#67 is finished, this requires discussion if we want to EPERM on that. Signed-off-by: Adrian Cole <[email protected]>
tetratelabs · Mar 21, 2023 · 046af43 · 046af43
1 parent a43a0f1
commit 046af43
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/.github/wasi_testsuite_skip.json b/.github/wasi_testsuite_skip.json
@@ -0,0 +1,5 @@
+{
+  "WASI Rust tests": {
+    "interesting_paths": "config is broken, and after fixing it forbids leading slash with EPERM"
+  }
+}
diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
@@ -304,6 +304,7 @@ jobs:
             -t ./tests/assemblyscript/testsuite/ \
             ./tests/c/testsuite/ \
             ./tests/rust/testsuite/ \
+            -f ../.github/wasi_testsuite_skip.json \
             -r ../.github/wasi_testsuite_adapter.py
 
   build_gojs_test_binaries:

diff --git a/imports/wasi_snapshot_preview1/fs_test.go b/imports/wasi_snapshot_preview1/fs_test.go
@@ -164,11 +164,11 @@ func Test_fdClose(t *testing.T) {
 `, "\n"+log.String())
 	})
 	log.Reset()
-	t.Run("ErrnoNotsup for a preopen", func(t *testing.T) {
-		requireErrnoResult(t, ErrnoNotsup, mod, FdCloseName, uint64(sys.FdPreopen))
+	t.Run("Can close a pre-open", func(t *testing.T) {
+		requireErrnoResult(t, ErrnoSuccess, mod, FdCloseName, uint64(sys.FdPreopen))
 		require.Equal(t, `
 ==> wasi_snapshot_preview1.fd_close(fd=3)
-<== errno=ENOTSUP
+<== errno=ESUCCESS
 `, "\n"+log.String())
 	})
 }

diff --git a/internal/sys/fs.go b/internal/sys/fs.go
@@ -447,10 +447,6 @@ func (c *FSContext) CloseFile(fd uint32) error {
 	f, ok := c.openedFiles.Lookup(fd)
 	if !ok {
 		return syscall.EBADF
-	} else if f.IsPreopen {
-		// WASI is the only user of pre-opens and wasi-testsuite disallows this
-		// See https://github.com/WebAssembly/wasi-testsuite/issues/50
-		return syscall.ENOTSUP
 	}
 	c.openedFiles.Delete(fd)
 	return f.File.Close()

diff --git a/internal/sys/fs_test.go b/internal/sys/fs_test.go
@@ -125,8 +125,8 @@ func TestFSContext_CloseFile(t *testing.T) {
 	t.Run("EBADF for an invalid FD", func(t *testing.T) {
 		require.Equal(t, syscall.EBADF, fsc.CloseFile(42)) // 42 is an arbitrary invalid FD
 	})
-	t.Run("ENOTSUP for a preopen", func(t *testing.T) {
-		require.Equal(t, syscall.ENOTSUP, fsc.CloseFile(FdPreopen)) // 42 is an arbitrary invalid FD
+	t.Run("Can close a pre-open", func(t *testing.T) {
+		require.NoError(t, fsc.CloseFile(FdPreopen))
 	})
 }