Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Explicitly mark parameters as nullable #231

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Chore: Explicitly mark parameters as nullable #231

merged 1 commit into from
Nov 26, 2024

Conversation

RikudouSage
Copy link
Collaborator

Description

Implicitly nullable types are deprecated as of PHP 8.4 released a few days ago.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage changed the title Chore/nullable type Chore: Explicitly mark parameters as nullable Nov 22, 2024
sighphyre
sighphyre approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM!

@RikudouSage RikudouSage merged commit db097e2 into main Nov 26, 2024
12 checks passed
@RikudouSage RikudouSage deleted the chore/nullable-type branch November 26, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RikudouSage @sighphyre