Chore: Explicitly mark parameters as nullable

.php-cs-fixer.dist.php

@@ -66,6 +66,7 @@
         'no_whitespace_before_comma_in_array' => true,
         'no_whitespace_in_blank_line' => true,
         'normalize_index_brace' => true,
+        'nullable_type_declaration_for_default_null_value' => true,
         'object_operator_without_whitespace' => true,
         'ordered_class_elements' => true,
         'ordered_imports' => true,

src/Metrics/DefaultMetricsHandler.php

@@ -18,7 +18,7 @@ public function __construct(
     }
 
     #[Override]
-    public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+    public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
     {
         if (!$this->configuration->isMetricsEnabled()) {
             return;

src/Metrics/MetricsHandler.php

@@ -7,5 +7,5 @@
 
 interface MetricsHandler
 {
-    public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void;
+    public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void;
 }

tests/AbstractHttpClientTestCase.php

@@ -92,7 +92,7 @@ protected function setUp(): void
         );
 
         $this->metricsHandler = new class implements MetricsHandler {
-            public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+            public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
             {
             }
         };

tests/ClientSpecificationTest.php

@@ -53,7 +53,7 @@ public function testClientSpecifications()
             $this->registrationService,
             $configuration,
             new class implements MetricsHandler {
-                public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+                public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
                 {
                 }
             },

tests/Configuration/UnleashContextTest.php

@@ -185,7 +185,7 @@ public function testCurrentTimeE2E()
                 ->setAutoRegistrationEnabled(false)
                 ->setCache($this->getCache()),
             new class implements MetricsHandler {
-                public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+                public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
                 {
                 }
             },

tests/ConstraintValidator/Operator/AbstractOperatorValidatorTest.php

@@ -53,7 +53,7 @@ public function testMissingValues()
                 ->setMetricsEnabled(false)
                 ->setAutoRegistrationEnabled(false),
             new class implements MetricsHandler {
-                public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+                public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
                 {
                 }
             },

tests/TestHelpers/DependencyContainer/CacheAwareMetricsHandler.php

@@ -20,7 +20,7 @@ public function setCache(CacheInterface $cache): void
         $this->cache = $cache;
     }
 
-    public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+    public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
     {
     }
 }

tests/TestHelpers/DependencyContainer/ConfigurationAwareMetricsHandler.php

@@ -20,7 +20,7 @@ public function setConfiguration(UnleashConfiguration $configuration): void
         $this->configuration = $configuration;
     }
 
-    public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+    public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
     {
     }
 }

tests/TestHelpers/DependencyContainer/MetricsSenderAwareMetricsHandler.php

@@ -15,7 +15,7 @@ final class MetricsSenderAwareMetricsHandler implements MetricsHandler, MetricsS
      */
     public $metricsSender = null;
 
-    public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+    public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
     {
     }
 

tests/TestHelpers/DependencyContainer/RequestFactoryAwareEventDispatcher.php

@@ -15,7 +15,7 @@ final class RequestFactoryAwareEventDispatcher implements EventDispatcherInterfa
      */
     public $requestFactory = null;
 
-    public function dispatch(object $event, string $eventName = null): object
+    public function dispatch(object $event, ?string $eventName = null): object
     {
         return new stdClass();
     }
@@ -41,7 +41,7 @@ public function removeSubscriber(EventSubscriberInterface $subscriber): void
     {
     }
 
-    public function getListeners(string $eventName = null): array
+    public function getListeners(?string $eventName = null): array
     {
         return [];
     }
@@ -51,7 +51,7 @@ public function getListenerPriority(string $eventName, callable $listener): ?int
         return null;
     }
 
-    public function hasListeners(string $eventName = null): bool
+    public function hasListeners(?string $eventName = null): bool
     {
         return false;
     }

tests/UnleashBuilderTest.php

@@ -769,7 +769,7 @@ public function testWithMetricsCacheHandler()
     public function testWithMetricsHandler()
     {
         $metricsHandler = new class implements MetricsHandler {
-            public function handleMetrics(Feature $feature, bool $successful, Variant $variant = null): void
+            public function handleMetrics(Feature $feature, bool $successful, ?Variant $variant = null): void
             {
             }
         };