Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply COPIERTemplate 0.6.0 with minimum optional questions #50

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Jun 11, 2024

This applies the template with minimum options.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (34640a7) to head (48fd566).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   69.03%   66.53%   -2.51%     
==========================================
  Files           5        6       +1     
  Lines         197      254      +57     
==========================================
+ Hits          136      169      +33     
- Misses         61       85      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira requested review from suvayu and removed request for suvayu June 11, 2024 10:55
@abelsiqueira abelsiqueira marked this pull request as draft June 11, 2024 11:22
@abelsiqueira
Copy link
Member Author

The indentation size was 2 for most files except Julia, which led to many files being fixed.

@abelsiqueira abelsiqueira changed the title Apply COPIERTemplate 0.5.3 with minimum optional questions Apply COPIERTemplate 0.5.4 with minimum optional questions Jun 11, 2024
@abelsiqueira abelsiqueira marked this pull request as ready for review June 11, 2024 11:42
@abelsiqueira abelsiqueira requested a review from suvayu June 11, 2024 11:47
Copy link
Member

@suvayu suvayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

.github/workflows/CompatHelper.yml Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this and contributing are 90-*.md, shouldn't one of them be 91-*.md? I'm presuming the number is for deterministic ordering.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I will rename them in the template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/make.jl Show resolved Hide resolved
suvayu
suvayu previously approved these changes Jun 13, 2024
Copy link
Member

@suvayu suvayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After renaming <num>-*.md to be in the correct sequence, everything should be good.

@abelsiqueira
Copy link
Member Author

I've updated (using COPIERTemplate.update) to 0.6.0, which includes the name change. It was also a good test for the tool.

@abelsiqueira abelsiqueira requested a review from suvayu June 14, 2024 17:28
@abelsiqueira abelsiqueira merged commit e843fd1 into main Jun 17, 2024
6 of 7 checks passed
@abelsiqueira abelsiqueira deleted the apply-template branch June 17, 2024 10:13
@abelsiqueira abelsiqueira changed the title Apply COPIERTemplate 0.5.4 with minimum optional questions Apply COPIERTemplate 0.6.0 with minimum optional questions Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants