Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minor-and-patch group with 3 updates #537

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Bump the minor-and-patch group with 3 updates #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
367fad3
Bump the minor-and-patch group with 3 updates
dependabot[bot] Apr 15, 2024
8ea466e
Set fetch-metadata to v2
KaanOzkan Apr 17, 2024
e961e25
Run bundle_install before each deadcode test
KaanOzkan Apr 18, 2024
f56ab12
Ignore warning from srb tc in test expectation
KaanOzkan Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dependabot_automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:
- name: Dependabot metadata
id: metadata
uses: dependabot/fetch-metadata@v2.0
uses: dependabot/fetch-metadata@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 2.0 doesn't exist, I think aim was to not specify the patch version to reduce the version bump PRs so I opted for v2 instead of v2.0.0

with:
github-token: "${{ secrets.GITHUB_TOKEN }}"
- name: Enable auto-merge for Dependabot PRs
Expand Down
26 changes: 13 additions & 13 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ GEM
irb (1.12.0)
rdoc
reline (>= 0.4.2)
json (2.7.1)
json (2.7.2)
language_server-protocol (3.17.0.3)
minitest (5.22.3)
minitest-reporters (1.6.1)
Expand All @@ -40,7 +40,7 @@ GEM
racc (1.7.3)
rainbow (3.1.1)
rake (13.2.1)
rbi (0.1.9)
rbi (0.1.10)
prism (>= 0.18.0, < 0.25)
sorbet-runtime (>= 0.5.9204)
rdoc (6.6.3.1)
Expand All @@ -49,7 +49,7 @@ GEM
reline (0.5.0)
io-console (~> 0.5)
rexml (3.2.6)
rubocop (1.62.1)
rubocop (1.63.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand All @@ -64,19 +64,19 @@ GEM
parser (>= 3.3.0.4)
rubocop-shopify (2.15.1)
rubocop (~> 1.51)
rubocop-sorbet (0.8.0)
rubocop-sorbet (0.8.1)
rubocop (>= 0.90.0)
ruby-progressbar (1.13.0)
sorbet (0.5.11332)
sorbet-static (= 0.5.11332)
sorbet-runtime (0.5.11332)
sorbet-static (0.5.11332-universal-darwin)
sorbet-static (0.5.11332-x86_64-linux)
sorbet-static-and-runtime (0.5.11332)
sorbet (= 0.5.11332)
sorbet-runtime (= 0.5.11332)
sorbet (0.5.11346)
sorbet-static (= 0.5.11346)
sorbet-runtime (0.5.11346)
sorbet-static (0.5.11346-universal-darwin)
sorbet-static (0.5.11346-x86_64-linux)
sorbet-static-and-runtime (0.5.11346)
sorbet (= 0.5.11346)
sorbet-runtime (= 0.5.11346)
stringio (3.1.0)
tapioca (0.13.1)
tapioca (0.13.3)
bundler (>= 2.2.25)
netrc (>= 0.11.0)
parallel (>= 1.21.0)
Expand Down
4 changes: 4 additions & 0 deletions test/spoom/cli/deadcode_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
module Spoom
module Cli
class DeadcodeTest < TestWithProject
def setup
@project.bundle_install!
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flakey errors seems to go away with this. We don't actually run it for each project, it's too slow. We can keep fixing them like this as they come up.


def test_deadcode_without_deadcode
@project.write!("lib/foo.rb", <<~RUBY)
def foo; end
Expand Down
2 changes: 1 addition & 1 deletion test/spoom/context/sorbet_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_context_run_srb_from_bundle

context.write_sorbet_config!(".")
res = context.srb("tc")
assert_equal(<<~ERR, res.err)
assert_includes(res.err, <<~ERR)
a.rb:3: Method `foo` does not exist on `T.class_of(<root>)` https://srb.help/7003
3 |foo(42)
^^^
Expand Down
Loading