Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minor-and-patch group with 3 updates #537

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 15, 2024

Bumps the minor-and-patch group with 3 updates: rubocop-sorbet, tapioca and sorbet-static-and-runtime.

Updates rubocop-sorbet from 0.8.0 to 0.8.1

Release notes

Sourced from rubocop-sorbet's releases.

v0.8.1

What's Changed

🛠 Other Changes

New Contributors

Full Changelog: Shopify/rubocop-sorbet@v0.8.0...v0.8.1

Commits
  • 479aaef Bump version to v0.8.1
  • 23b9d82 Merge pull request #221 from Shopify/dependabot/bundler/rake-13.2.1
  • 1eb6517 Bump rake from 13.1.0 to 13.2.1
  • d5f72a2 Merge pull request #218 from Shopify/centralize_ruby_version
  • 107aa2e Remove TargetRubyVersion from config/rbi.yml
  • c15a2d2 Update Rubocop to 1.62.1
  • b43acc9 Centralize Ruby Version to .ruby-version
  • 7c44e60 Merge pull request #212 from Shopify/dependabot/github_actions/actions/stale-9
  • c5d0a19 Merge pull request #211 from Shopify/dependabot/github_actions/actions/checko...
  • b6b33d7 Merge pull request #216 from Shopify/dependabot/bundler/rspec-3.13.0
  • Additional commits viewable in compare view

Updates tapioca from 0.13.1 to 0.13.3

Release notes

Sourced from tapioca's releases.

v0.13.3

What's Changed

🐛 Bug Fixes

New Contributors

Full Changelog: Shopify/tapioca@v0.13.2...v0.13.3

v0.13.2

What's Changed

🚧 Breaking Changes

✨ Enhancements

🛠 Other Changes

New Contributors

Full Changelog: Shopify/tapioca@v0.13.1...v0.13.2

Commits
  • f00b6c1 Bump version to v0.13.3
  • d4034fc Merge pull request #1867 from Shopify/fix_invalid-ar-find-output
  • 01b7880 Remove extra ) in the ActiveRecord.find output
  • 37e48be Bump version to v0.13.2
  • 4f4b9ed Merge pull request #1866 from Shopify/KaanOzkan-patch-1
  • 1daf684 Specify rails
  • ae9ee97 Specify DSL compiler contributions in README
  • cdc0d7c Disable all permissions for action
  • 5e946e9 Sanitize branch input
  • 032e04f Merge pull request #1860 from bdewater/ar-count-block
  • Additional commits viewable in compare view

Updates sorbet-static-and-runtime from 0.5.11332 to 0.5.11346

Release notes

Sourced from sorbet-static-and-runtime's releases.

sorbet 0.5.11345.20240412161526-5c0012a52

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11345', :group => :development
gem 'sorbet-runtime', '0.5.11345'

sorbet 0.5.11344.20240412111932-3afd7e5b7

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11344', :group => :development
gem 'sorbet-runtime', '0.5.11344'

sorbet 0.5.11343.20240412093356-2f9b15f81

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11343', :group => :development
gem 'sorbet-runtime', '0.5.11343'

sorbet 0.5.11342.20240411132013-f6c67ae4c

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11342', :group => :development
gem 'sorbet-runtime', '0.5.11342'

sorbet 0.5.11341.20240411105921-81f7617ed

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11341', :group => :development
gem 'sorbet-runtime', '0.5.11341'

sorbet 0.5.11340.20240410150614-443cd113c

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11340', :group => :development
gem 'sorbet-runtime', '0.5.11340'

sorbet 0.5.11339.20240410120813-d5bba0907

To use Sorbet add this line to your Gemfile:

gem 'sorbet', '0.5.11339', :group => :development
gem 'sorbet-runtime', '0.5.11339'

sorbet 0.5.11338.20240409113636-5cec8509e

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the minor-and-patch group with 3 updates: [rubocop-sorbet](https://github.com/shopify/rubocop-sorbet), [tapioca](https://github.com/Shopify/tapioca) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet).


Updates `rubocop-sorbet` from 0.8.0 to 0.8.1
- [Release notes](https://github.com/shopify/rubocop-sorbet/releases)
- [Commits](Shopify/rubocop-sorbet@v0.8.0...v0.8.1)

Updates `tapioca` from 0.13.1 to 0.13.3
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](Shopify/tapioca@v0.13.1...v0.13.3)

Updates `sorbet-static-and-runtime` from 0.5.11332 to 0.5.11346
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: rubocop-sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-and-patch
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-and-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: minor-and-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner April 15, 2024 21:39
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 15, 2024
@dependabot dependabot bot requested review from KaanOzkan and vinistock April 15, 2024 21:39
@andyw8
Copy link
Contributor

andyw8 commented Apr 16, 2024

Looks like there are some flaky tests:

bundler: command not found: spoom

@KaanOzkan KaanOzkan force-pushed the dependabot/bundler/minor-and-patch-6d0148a791 branch from 58dcbb8 to 881bdaf Compare April 17, 2024 22:59
@KaanOzkan KaanOzkan force-pushed the dependabot/bundler/minor-and-patch-6d0148a791 branch from 881bdaf to 7ea73d5 Compare April 18, 2024 20:13
@KaanOzkan KaanOzkan requested a review from Morriar April 18, 2024 20:26
@@ -12,7 +12,7 @@ jobs:
steps:
- name: Dependabot metadata
id: metadata
uses: dependabot/fetch-metadata@v2.0
uses: dependabot/fetch-metadata@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 2.0 doesn't exist, I think aim was to not specify the patch version to reduce the version bump PRs so I opted for v2 instead of v2.0.0

@@ -6,6 +6,10 @@
module Spoom
module Cli
class DeadcodeTest < TestWithProject
def setup
@project.bundle_install!
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flakey errors seems to go away with this. We don't actually run it for each project, it's too slow. We can keep fixing them like this as they come up.

@@ -44,7 +44,7 @@ def test_context_run_srb_from_bundle

context.write_sorbet_config!(".")
res = context.srb("tc")
assert_equal(<<~ERR, res.err)
assert_includes(<<~ERR, res.err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting warnings that Sorbet needs to add bigdecimal in its gemspec because it'll stop being bundled in 3.4.0 ruby/ruby@1c93288. Which clutters the stderr.

I can't reproduce the warning on a typecheck of the same file locally. So for now I didn't open a Sorbet PR for this.

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 22, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Apr 22, 2024
@dependabot dependabot bot deleted the dependabot/bundler/minor-and-patch-6d0148a791 branch April 22, 2024 21:17
@andyw8 andyw8 restored the dependabot/bundler/minor-and-patch-6d0148a791 branch April 23, 2024 14:45
@andyw8
Copy link
Contributor

andyw8 commented Apr 23, 2024

I don’t understand why this auto-closed, e.g. tapioca is still on 0.13.1 on main.

@andyw8 andyw8 reopened this Apr 23, 2024
@KaanOzkan KaanOzkan force-pushed the dependabot/bundler/minor-and-patch-6d0148a791 branch from 7ea73d5 to f56ab12 Compare April 23, 2024 23:48
@KaanOzkan KaanOzkan merged commit 256c6dd into main Apr 23, 2024
11 of 12 checks passed
@KaanOzkan KaanOzkan deleted the dependabot/bundler/minor-and-patch-6d0148a791 branch April 23, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants