-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minor-and-patch group with 3 updates #537
Bump the minor-and-patch group with 3 updates #537
Conversation
Bumps the minor-and-patch group with 3 updates: [rubocop-sorbet](https://github.com/shopify/rubocop-sorbet), [tapioca](https://github.com/Shopify/tapioca) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). Updates `rubocop-sorbet` from 0.8.0 to 0.8.1 - [Release notes](https://github.com/shopify/rubocop-sorbet/releases) - [Commits](Shopify/rubocop-sorbet@v0.8.0...v0.8.1) Updates `tapioca` from 0.13.1 to 0.13.3 - [Release notes](https://github.com/Shopify/tapioca/releases) - [Commits](Shopify/tapioca@v0.13.1...v0.13.3) Updates `sorbet-static-and-runtime` from 0.5.11332 to 0.5.11346 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: rubocop-sorbet dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: tapioca dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: sorbet-static-and-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Looks like there are some flaky tests:
|
58dcbb8
to
881bdaf
Compare
881bdaf
to
7ea73d5
Compare
@@ -12,7 +12,7 @@ jobs: | |||
steps: | |||
- name: Dependabot metadata | |||
id: metadata | |||
uses: dependabot/fetch-metadata@v2.0 | |||
uses: dependabot/fetch-metadata@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 2.0 doesn't exist, I think aim was to not specify the patch version to reduce the version bump PRs so I opted for v2
instead of v2.0.0
@@ -6,6 +6,10 @@ | |||
module Spoom | |||
module Cli | |||
class DeadcodeTest < TestWithProject | |||
def setup | |||
@project.bundle_install! | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flakey errors seems to go away with this. We don't actually run it for each project, it's too slow. We can keep fixing them like this as they come up.
test/spoom/context/sorbet_test.rb
Outdated
@@ -44,7 +44,7 @@ def test_context_run_srb_from_bundle | |||
|
|||
context.write_sorbet_config!(".") | |||
res = context.srb("tc") | |||
assert_equal(<<~ERR, res.err) | |||
assert_includes(<<~ERR, res.err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting warnings that Sorbet needs to add bigdecimal
in its gemspec because it'll stop being bundled in 3.4.0 ruby/ruby@1c93288. Which clutters the stderr.
I can't reproduce the warning on a typecheck of the same file locally. So for now I didn't open a Sorbet PR for this.
Looks like these dependencies are updatable in another way, so this is no longer needed. |
I don’t understand why this auto-closed, e.g. tapioca is still on 0.13.1 on main. |
7ea73d5
to
f56ab12
Compare
Bumps the minor-and-patch group with 3 updates: rubocop-sorbet, tapioca and sorbet-static-and-runtime.
Updates
rubocop-sorbet
from 0.8.0 to 0.8.1Release notes
Sourced from rubocop-sorbet's releases.
Commits
479aaef
Bump version to v0.8.123b9d82
Merge pull request #221 from Shopify/dependabot/bundler/rake-13.2.11eb6517
Bump rake from 13.1.0 to 13.2.1d5f72a2
Merge pull request #218 from Shopify/centralize_ruby_version107aa2e
Remove TargetRubyVersion fromconfig/rbi.yml
c15a2d2
Update Rubocop to 1.62.1b43acc9
Centralize Ruby Version to.ruby-version
7c44e60
Merge pull request #212 from Shopify/dependabot/github_actions/actions/stale-9c5d0a19
Merge pull request #211 from Shopify/dependabot/github_actions/actions/checko...b6b33d7
Merge pull request #216 from Shopify/dependabot/bundler/rspec-3.13.0Updates
tapioca
from 0.13.1 to 0.13.3Release notes
Sourced from tapioca's releases.
Commits
f00b6c1
Bump version to v0.13.3d4034fc
Merge pull request #1867 from Shopify/fix_invalid-ar-find-output01b7880
Remove extra ) in the ActiveRecord.find output37e48be
Bump version to v0.13.24f4b9ed
Merge pull request #1866 from Shopify/KaanOzkan-patch-11daf684
Specify railsae9ee97
Specify DSL compiler contributions in READMEcdc0d7c
Disable all permissions for action5e946e9
Sanitize branch input032e04f
Merge pull request #1860 from bdewater/ar-count-blockUpdates
sorbet-static-and-runtime
from 0.5.11332 to 0.5.11346Release notes
Sourced from sorbet-static-and-runtime's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions