Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AK UI test fix #17631

Merged
merged 3 commits into from
Feb 20, 2025
Merged

AK UI test fix #17631

merged 3 commits into from
Feb 20, 2025

Conversation

LadislavVasina1
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 commented Feb 19, 2025 •
edited
Loading

Problem Statement

One AK UI test was failing due to outdated airgun and test composition

Solution

This PR and Related Airgun PR fixes this test

Related issues

This PR needs SatelliteQE/airgun#1744

image

RHEL9 test fails with,

500 Server Error: Internal Server Error (can only create exec sessions on running containers: container state improper)

thus not related to this PR.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k 'test_negative_usage_limit'
airgun: 1744

@LadislavVasina1 LadislavVasina1 added UI Issues and PRs involving the UI No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 19, 2025
@LadislavVasina1 LadislavVasina1 self-assigned this Feb 19, 2025
@LadislavVasina1 LadislavVasina1 requested a review from a team as a code owner February 19, 2025 07:20
@LadislavVasina1 LadislavVasina1 mentioned this pull request Feb 19, 2025
Merged
@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k 'test_negative_usage_limit'
airgun: 1744

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10238
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_activationkey.py -k test_negative_usage_limit --external-logging
Test Result : ====== 2 passed, 54 deselected, 98 warnings, 1 error in 799.73s (0:13:19) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 19, 2025
@LadislavVasina1 LadislavVasina1 added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 19, 2025
@LadislavVasina1
Copy link
Contributor Author

PRT failed as expected with just rhel9 test (500 code), others passed

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 19, 2025
vsedmik
vsedmik approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@LadislavVasina1
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_activationkey.py -k 'test_negative_usage_limit'
airgun: 1744

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10239
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_activationkey.py -k test_negative_usage_limit --external-logging
Test Result : ====== 2 passed, 54 deselected, 99 warnings, 1 error in 798.83s (0:13:18) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 19, 2025
@LadislavVasina1
Copy link
Contributor Author

LadislavVasina1 commented Feb 19, 2025 •
edited
Loading

Code quality seems to be broken now, unrelated to PR

@LadislavVasina1 LadislavVasina1 added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 19, 2025
damoore044
damoore044 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix looks good!

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 20, 2025
@vsedmik
Copy link
Contributor

vsedmik commented Feb 20, 2025

Just rebased.

@vsedmik vsedmik merged commit 5528067 into SatelliteQE:master Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@damoore044 damoore044 damoore044 approved these changes

@vijaysawant vijaysawant Awaiting requested review from vijaysawant

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

Assignees

@LadislavVasina1 LadislavVasina1

Labels
No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LadislavVasina1 @Satellite-QE @vsedmik @damoore044