Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AK update host limit entity #1744

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

LadislavVasina1
Copy link
Contributor

This PR adds an entity that enables modification of the AK host limit and adds some missing view elements.
Dependant PR SatelliteQE/robottelo#17631

@LadislavVasina1 LadislavVasina1 added entity Related to entity coverage view Issues related to Views coverage No-CherryPick PR doesnt need CherryPick to previous branches Stream labels Feb 19, 2025
@LadislavVasina1 LadislavVasina1 self-assigned this Feb 19, 2025
@LadislavVasina1 LadislavVasina1 requested review from vsedmik, vijaysawant and a team February 19, 2025 07:25
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LadislavVasina1 LadislavVasina1 requested review from ColeHiggins2 and a team February 19, 2025 09:00
Comment on lines +88 to +97
unlimited_content_host_checkbox = Checkbox(
locator='//input[@ng-model="activationKey.unlimited_hosts"]'
)
host_limit_input = TextInput(locator='//input[@ng-model="activationKey.max_hosts"]')
host_limit_save_btn = Text(
locator='//dd[contains(@bst-edit-custom, "activationKey.max_hosts")]//button[@ng-click="save()"]'
)
host_limit_cancel_btn = Text(
locator='//dd[contains(@bst-edit-custom, "activationKey.max_hosts")]//button[@ng-click="cancel()"]'
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also modify host limit on the new AK page. Would it be appropriate to add support for that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that new PR would be more appropriate for it

@vsedmik vsedmik merged commit 955087f into SatelliteQE:master Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entity Related to entity coverage No-CherryPick PR doesnt need CherryPick to previous branches Stream view Issues related to Views coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants