Add use statements for all classes

Payum · Nov 6, 2023 · 39abdb0 · 39abdb0
1 parent cfb28d5
commit 39abdb0
Show file tree

Hide file tree

Showing 13 changed files with 83 additions and 52 deletions.
diff --git a/Action/CaptureAction.php b/Action/CaptureAction.php
@@ -2,6 +2,7 @@
 
 namespace Payum\Be2Bill\Action;
 
+use ArrayAccess;
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\ApiAwareInterface;
@@ -88,7 +89,7 @@ public function execute($request)
     public function supports($request)
     {
         return $request instanceof Capture &&
-            $request->getModel() instanceof \ArrayAccess
+            $request->getModel() instanceof ArrayAccess
         ;
     }
 }
diff --git a/Action/CaptureOffsiteAction.php b/Action/CaptureOffsiteAction.php
@@ -2,6 +2,7 @@
 
 namespace Payum\Be2Bill\Action;
 
+use ArrayAccess;
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\ApiAwareInterface;
@@ -73,7 +74,7 @@ public function execute($request)
     public function supports($request)
     {
         return $request instanceof Capture &&
-            $request->getModel() instanceof \ArrayAccess
+            $request->getModel() instanceof ArrayAccess
         ;
     }
 }
diff --git a/Action/NotifyAction.php b/Action/NotifyAction.php
@@ -2,6 +2,7 @@
 
 namespace Payum\Be2Bill\Action;
 
+use ArrayAccess;
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\ApiAwareInterface;
@@ -51,7 +52,7 @@ public function execute($request)
     public function supports($request)
     {
         return $request instanceof Notify &&
-            $request->getModel() instanceof \ArrayAccess
+            $request->getModel() instanceof ArrayAccess
         ;
     }
 }
diff --git a/Action/StatusAction.php b/Action/StatusAction.php
@@ -2,6 +2,7 @@
 
 namespace Payum\Be2Bill\Action;
 
+use ArrayAccess;
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\Bridge\Spl\ArrayObject;
@@ -43,7 +44,7 @@ public function execute($request)
     public function supports($request)
     {
         return $request instanceof GetStatusInterface &&
-            $request->getModel() instanceof \ArrayAccess
+            $request->getModel() instanceof ArrayAccess
             ;
     }
 }
diff --git a/Api.php b/Api.php
@@ -5,6 +5,7 @@
 use Http\Message\MessageFactory;
 use Payum\Core\Bridge\Spl\ArrayObject;
 use Payum\Core\Exception\Http\HttpException;
+use Payum\Core\Exception\InvalidArgumentException;
 use Payum\Core\Exception\LogicException;
 use Payum\Core\HttpClientInterface;
 
@@ -122,7 +123,7 @@ class Api
     ];
 
     /**
-     * @throws \Payum\Core\Exception\InvalidArgumentException if an option is invalid
+     * @throws InvalidArgumentException if an option is invalid
      */
     public function __construct(array $options, HttpClientInterface $client, MessageFactory $messageFactory)
     {

diff --git a/Tests/Action/CaptureActionTest.php b/Tests/Action/CaptureActionTest.php
@@ -2,11 +2,15 @@
 
 namespace Payum\Be2Bill\Tests\Action;
 
+use ArrayObject;
+use DateTime;
 use Payum\Be2Bill\Action\CaptureAction;
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\ApiAwareInterface;
+use Payum\Core\Exception\LogicException;
 use Payum\Core\Exception\RequestNotSupportedException;
+use Payum\Core\Exception\UnsupportedApiException;
 use Payum\Core\GatewayAwareInterface;
 use Payum\Core\GatewayInterface;
 use Payum\Core\Model\CreditCard;
@@ -15,6 +19,9 @@
 use Payum\Core\Request\ObtainCreditCard;
 use Payum\Core\Security\SensitiveValue;
 use Payum\Core\Tests\GenericActionTest;
+use PHPUnit\Framework\MockObject\MockObject;
+use ReflectionClass;
+use stdClass;
 
 class CaptureActionTest extends GenericActionTest
 {
@@ -24,42 +31,42 @@ class CaptureActionTest extends GenericActionTest
 
     public function testShouldImplementActionInterface()
     {
-        $rc = new \ReflectionClass(CaptureAction::class);
+        $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(ActionInterface::class));
     }
 
     public function testShouldImplementGatewayAwareInterface()
     {
-        $rc = new \ReflectionClass(CaptureAction::class);
+        $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(GatewayAwareInterface::class));
     }
 
     public function testShouldImplementApiAwareInterface()
     {
-        $rc = new \ReflectionClass(CaptureAction::class);
+        $rc = new ReflectionClass(CaptureAction::class);
 
         $this->assertTrue($rc->implementsInterface(ApiAwareInterface::class));
     }
 
     public function testThrowIfUnsupportedApiGiven()
     {
-        $this->expectException(\Payum\Core\Exception\UnsupportedApiException::class);
+        $this->expectException(UnsupportedApiException::class);
         $action = new CaptureAction();
 
-        $action->setApi(new \stdClass());
+        $action->setApi(new stdClass());
     }
 
     public function testThrowIfCreditCardNotSetExplicitlyAndObtainRequestNotSupportedOnCapture()
     {
-        $this->expectException(\Payum\Core\Exception\LogicException::class);
+        $this->expectException(LogicException::class);
         $this->expectExceptionMessage('Credit card details has to be set explicitly or there has to be an action that supports ObtainCreditCard request.');
         $gatewayMock = $this->createGatewayMock();
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
+            ->with($this->isInstanceOf(ObtainCreditCard::class))
             ->willThrowException(new RequestNotSupportedException())
         ;
 
@@ -155,11 +162,11 @@ public function testShouldCaptureWithObtainedCreditCard()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
+            ->with($this->isInstanceOf(ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) {
                 $card = new CreditCard();
                 $card->setNumber('1234567812345678');
-                $card->setExpireAt(new \DateTime('2014-10-01'));
+                $card->setExpireAt(new DateTime('2014-10-01'));
                 $card->setHolder('John Doe');
                 $card->setSecurityCode('123');
 
@@ -211,7 +218,7 @@ public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
+            ->with($this->isInstanceOf(ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) {
                 $card = new CreditCard();
                 $card->setToken('theCreditCardToken');
@@ -259,8 +266,8 @@ public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned()
 
     public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubRequest()
     {
-        $firstModel = new \stdClass();
-        $currentModel = new \ArrayObject([
+        $firstModel = new stdClass();
+        $currentModel = new ArrayObject([
             'AMOUNT' => 10,
             'CLIENTUSERAGENT' => 'anAgent',
             'CLIENTIP' => '127.0.0.1',
@@ -280,13 +287,13 @@ public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubReques
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
+            ->with($this->isInstanceOf(ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) use ($firstModel, $currentModel) {
                 $this->assertSame($firstModel, $request->getFirstModel());
                 $this->assertSame($currentModel, $request->getModel());
 
                 $card = new CreditCard();
-                $card->setExpireAt(new \DateTime('2014-10-01'));
+                $card->setExpireAt(new DateTime('2014-10-01'));
 
                 $request->set($card);
             })
@@ -314,15 +321,15 @@ public function testShouldThrowHttpResponseIfExecCode3DSecureRequired()
     }
 
     /**
-     * @return \PHPUnit\Framework\MockObject\MockObject|Api
+     * @return MockObject|Api
      */
     protected function createApiMock()
     {
         return $this->createMock(Api::class, [], [], '', false);
     }
 
     /**
-     * @return \PHPUnit\Framework\MockObject\MockObject|GatewayInterface
+     * @return MockObject|GatewayInterface
      */
     protected function createGatewayMock()
     {

diff --git a/Tests/Action/CaptureOffsiteActionTest.php b/Tests/Action/CaptureOffsiteActionTest.php
@@ -6,11 +6,16 @@
 use Payum\Be2Bill\Api;
 use Payum\Core\Action\ActionInterface;
 use Payum\Core\ApiAwareInterface;
+use Payum\Core\Exception\UnsupportedApiException;
 use Payum\Core\GatewayAwareInterface;
 use Payum\Core\GatewayInterface;
+use Payum\Core\Reply\HttpPostRedirect;
 use Payum\Core\Request\Capture;
 use Payum\Core\Request\GetHttpRequest;
 use Payum\Core\Tests\GenericActionTest;
+use PHPUnit\Framework\MockObject\MockObject;
+use ReflectionClass;
+use stdClass;
 
 class CaptureOffsiteActionTest extends GenericActionTest
 {
@@ -20,36 +25,36 @@ class CaptureOffsiteActionTest extends GenericActionTest
 
     public function testShouldImplementActionInterface()
     {
-        $rc = new \ReflectionClass(CaptureOffsiteAction::class);
+        $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(ActionInterface::class));
     }
 
     public function testShouldImplementGatewayAwareInterface()
     {
-        $rc = new \ReflectionClass(CaptureOffsiteAction::class);
+        $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(GatewayAwareInterface::class));
     }
 
     public function testShouldImplementApiAwareInterface()
     {
-        $rc = new \ReflectionClass(CaptureOffsiteAction::class);
+        $rc = new ReflectionClass(CaptureOffsiteAction::class);
 
         $this->assertTrue($rc->implementsInterface(ApiAwareInterface::class));
     }
 
     public function testThrowIfUnsupportedApiGiven()
     {
-        $this->expectException(\Payum\Core\Exception\UnsupportedApiException::class);
+        $this->expectException(UnsupportedApiException::class);
         $action = new CaptureOffsiteAction();
 
-        $action->setApi(new \stdClass());
+        $action->setApi(new stdClass());
     }
 
     public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery()
     {
-        $this->expectException(\Payum\Core\Reply\HttpPostRedirect::class);
+        $this->expectException(HttpPostRedirect::class);
         $model = [
             'AMOUNT' => 1000,
             'CLIENTIDENT' => 'payerId',
@@ -74,7 +79,7 @@ public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\GetHttpRequest::class))
+            ->with($this->isInstanceOf(GetHttpRequest::class))
         ;
 
         $action = new CaptureOffsiteAction();
@@ -105,7 +110,7 @@ public function testShouldUpdateModelWhenComeBackFromBe2billSite()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf(\Payum\Core\Request\GetHttpRequest::class))
+            ->with($this->isInstanceOf(GetHttpRequest::class))
             ->willReturnCallback(function (GetHttpRequest $request) {
                 $request->query['EXECCODE'] = 1;
                 $request->query['FOO'] = 'fooVal';
@@ -132,15 +137,15 @@ public function testShouldUpdateModelWhenComeBackFromBe2billSite()
     }
 
     /**
-     * @return \PHPUnit\Framework\MockObject\MockObject|Api
+     * @return MockObject|Api
      */
     protected function createApiMock()
     {
         return $this->createMock(Api::class, [], [], '', false);
     }
 
     /**
-     * @return \PHPUnit\Framework\MockObject\MockObject|GatewayInterface
+     * @return MockObject|GatewayInterface
      */
     protected function createGatewayMock()
     {

diff --git a/Tests/Action/ConvertPaymentActionTest.php b/Tests/Action/ConvertPaymentActionTest.php
@@ -2,32 +2,36 @@
 
 namespace Payum\Be2Bill\Tests\Action;
 
+use Iterator;
 use Payum\Be2Bill\Action\ConvertPaymentAction;
 use Payum\Core\Model\Payment;
 use Payum\Core\Model\PaymentInterface;
 use Payum\Core\Request\Convert;
+use Payum\Core\Request\Generic;
+use Payum\Core\Security\TokenInterface;
 use Payum\Core\Tests\GenericActionTest;
+use stdClass;
 
 class ConvertPaymentActionTest extends GenericActionTest
 {
     protected $actionClass = ConvertPaymentAction::class;
 
     protected $requestClass = Convert::class;
 
-    public function provideSupportedRequests(): \Iterator
+    public function provideSupportedRequests(): Iterator
     {
         yield [new $this->requestClass(new Payment(), 'array')];
         yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'array')];
-        yield [new $this->requestClass(new Payment(), 'array', $this->createMock(\Payum\Core\Security\TokenInterface::class))];
+        yield [new $this->requestClass(new Payment(), 'array', $this->createMock(TokenInterface::class))];
     }
 
-    public function provideNotSupportedRequests(): \Iterator
+    public function provideNotSupportedRequests(): Iterator
     {
         yield ['foo'];
         yield [['foo']];
-        yield [new \stdClass()];
-        yield [$this->getMockForAbstractClass(\Payum\Core\Request\Generic::class, [[]])];
-        yield [new $this->requestClass(new \stdClass(), 'array')];
+        yield [new stdClass()];
+        yield [$this->getMockForAbstractClass(Generic::class, [[]])];
+        yield [new $this->requestClass(new stdClass(), 'array')];
         yield [new $this->requestClass(new Payment(), 'foobar')];
         yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'foobar')];
     }