Replace string class names with class constant

Payum · Nov 6, 2023 · cfb28d5 · cfb28d5
1 parent 0b75cd6
commit cfb28d5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/Tests/Action/CaptureActionTest.php b/Tests/Action/CaptureActionTest.php
@@ -59,7 +59,7 @@ public function testThrowIfCreditCardNotSetExplicitlyAndObtainRequestNotSupporte
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\ObtainCreditCard'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
             ->willThrowException(new RequestNotSupportedException())
         ;
 
@@ -155,7 +155,7 @@ public function testShouldCaptureWithObtainedCreditCard()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\ObtainCreditCard'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) {
                 $card = new CreditCard();
                 $card->setNumber('1234567812345678');
@@ -211,7 +211,7 @@ public function testShouldCaptureWithObtainedCreditCardWhenTokenReturned()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\ObtainCreditCard'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) {
                 $card = new CreditCard();
                 $card->setToken('theCreditCardToken');
@@ -280,7 +280,7 @@ public function testShouldPassFirstAndCurrentModelsWithObtainCreditCardSubReques
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\ObtainCreditCard'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\ObtainCreditCard::class))
             ->willReturnCallback(function (ObtainCreditCard $request) use ($firstModel, $currentModel) {
                 $this->assertSame($firstModel, $request->getFirstModel());
                 $this->assertSame($currentModel, $request->getModel());

diff --git a/Tests/Action/CaptureOffsiteActionTest.php b/Tests/Action/CaptureOffsiteActionTest.php
@@ -74,7 +74,7 @@ public function testShouldRedirectToBe2billSiteIfExecCodeNotPresentInQuery()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\GetHttpRequest'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\GetHttpRequest::class))
         ;
 
         $action = new CaptureOffsiteAction();
@@ -105,7 +105,7 @@ public function testShouldUpdateModelWhenComeBackFromBe2billSite()
         $gatewayMock
             ->expects($this->once())
             ->method('execute')
-            ->with($this->isInstanceOf('Payum\Core\Request\GetHttpRequest'))
+            ->with($this->isInstanceOf(\Payum\Core\Request\GetHttpRequest::class))
             ->willReturnCallback(function (GetHttpRequest $request) {
                 $request->query['EXECCODE'] = 1;
                 $request->query['FOO'] = 'fooVal';

diff --git a/Tests/Action/ConvertPaymentActionTest.php b/Tests/Action/ConvertPaymentActionTest.php
@@ -18,15 +18,15 @@ public function provideSupportedRequests(): \Iterator
     {
         yield [new $this->requestClass(new Payment(), 'array')];
         yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'array')];
-        yield [new $this->requestClass(new Payment(), 'array', $this->createMock('Payum\Core\Security\TokenInterface'))];
+        yield [new $this->requestClass(new Payment(), 'array', $this->createMock(\Payum\Core\Security\TokenInterface::class))];
     }
 
     public function provideNotSupportedRequests(): \Iterator
     {
         yield ['foo'];
         yield [['foo']];
         yield [new \stdClass()];
-        yield [$this->getMockForAbstractClass('Payum\Core\Request\Generic', [[]])];
+        yield [$this->getMockForAbstractClass(\Payum\Core\Request\Generic::class, [[]])];
         yield [new $this->requestClass(new \stdClass(), 'array')];
         yield [new $this->requestClass(new Payment(), 'foobar')];
         yield [new $this->requestClass($this->createMock(PaymentInterface::class), 'foobar')];

diff --git a/Tests/ApiTest.php b/Tests/ApiTest.php
@@ -159,7 +159,7 @@ public function testShouldReturnTrueIfHashesMatched()
      */
     protected function createHttpClientMock()
     {
-        return $this->createMock('Payum\Core\HttpClientInterface');
+        return $this->createMock(\Payum\Core\HttpClientInterface::class);
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -159,7 +159,7 @@ public function testShouldReturnTrueIfHashesMatched() @@
          */
         protected function createHttpClientMock()
         {
-            return $this->createMock('Payum\Core\HttpClientInterface');
+            return $this->createMock(\Payum\Core\HttpClientInterface::class);
         }
         /**
@@ Expand Down @@