Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic Staking Strategy handling when a validator is fully slashed #2413

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

naddison36
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Feb 21, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against efe2fa2

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.65%. Comparing base (7f84aaa) to head (efe2fa2).
Report is 5 commits behind head on nicka/sonic-staking-oz-audit.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           nicka/sonic-staking-oz-audit    #2413      +/-   ##
================================================================
+ Coverage                         49.43%   51.65%   +2.21%     
================================================================
  Files                                94       94              
  Lines                              4717     4724       +7     
  Branches                           1251     1252       +1     
================================================================
+ Hits                               2332     2440     +108     
+ Misses                             2381     2280     -101     
  Partials                              4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 marked this pull request as ready for review February 24, 2025 05:27
@naddison36 naddison36 merged commit cdabe75 into nicka/sonic-staking-oz-audit Feb 24, 2025
16 of 19 checks passed
@naddison36 naddison36 deleted the nicka/sonic-staking-oz-M-01 branch February 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant