All changes from OZ's security audit of the Sonic Staking Strategy #2412
+274
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
=======================================
Coverage 49.43% 49.43%
=======================================
Files 94 94
Lines 4717 4717
Branches 1251 1251
=======================================
Hits 2332 2332
Misses 2381 2381
Partials 4 4 ☔ View full report in Codecov by Sentry. |
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro and
clement-ux
as code owners
) * Sonic Staking Strategy handling when a validator is fully slashed * Deploy script to upgrade the Sonic Staking Strategy * Added slashing to the SFC mock * Got partial and fully slashed validators working * Added withinRange Chai matcher Added messages to emittedEvent Chai matcher * Fixed the Sonic Staking Strategy fork tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Code Change Checklist
To be completed before internal review begins:
Internal review: