fix: resolve source graph in separate query #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlamoris
reviewed
Jan 24, 2024
| } | ||
| } | ||
|
|
||
| bind( |
There was a problem hiding this comment.
there's no need for all the binds here since it's just getting srcgraph
dlamoris
reviewed
Jan 31, 2024
There was a problem hiding this comment.
https://github.com/Open-MBEE/flexo-mms-layer1-service/pull/151/files#diff-f2a7130214501d39d26dcd3aa11666bdc0b1dd468985297a7006936889535f12R270-R284
is no longer needed and for whatever reason neptune is doing, is still causing issues when there's 2 or more locks (?srcSnapshot can have multiple results)
|
dlamoris
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
?srcGraphin a separate query prior to the transaction to avoid a critical performance issue with Neptune. Checks to make sure the result is distinct (1 result) and substitutes the variable in the subsequent transaction update.