haskell.packages.ghc910.haskell-language-server: fix package #337720
Conversation
eldritch-cookie
requested review from
sternenseemann and
maralorn
as code owners
| @@ -120,4 +123,8 @@ self: super: { | |||
| lukko_0_1_2 = dontCheck super.lukko_0_1_2; # doesn't compile with tasty ==1.4.* | |||
| resolv = dontCheck super.resolv; # doesn't compile with filepath ==1.5.* | |||
| primitive-unlifted = dontCheck super.primitive-unlifted; # doesn't compile with primitive ==0.9.* | |||
|
|
|||
| haskell-language-server = disableCabalFlag "retrie" (disableCabalFlag "hlint" (disableCabalFlag "stylishhaskel" (super.haskell-language-server.override {stylish-haskell = null;retrie = null;apply-refact=null;hlint = null;}))); | |||
There was a problem hiding this comment.
Do you want to convert this to use lib.pipe as discussed on matrix?
There was a problem hiding this comment.
i think 3 is about the limit where doing directly still is acceptable.
There was a problem hiding this comment.
Well, I personally use lib.pipe as soon as I hit 2 functions, but sure.
|
Ah, wait one more thing we should enable the hls job for 9.10 now. Can you drop the right line from release-haskell.nix (search for haskell-language-server)? |
i am so confused, how is this in anyway caused by my PR? |
| @@ -226391,7 +226411,6 @@ self: { | |||
| ]; | |||
| description = "Haskell binding to OpenCV-3.x extra modules"; | |||
| license = lib.licenses.bsd3; | |||
| hydraPlatforms = lib.platforms.none; | |||
There was a problem hiding this comment.
It's due to the removal of this line, which in turn eval'd opencv, which in turn resulted in the eval failure since opencv3 no longer exists.
Technically it was caused by 336141 not removing the opencv3 reference properly, but I'm not sure why we're touching opencv here when this PR is about hls.
There was a problem hiding this comment.
Tagging @emilazy as you might have more insight into this, I saw your comment about the dangling reference being desirable, and I don't get it.
There was a problem hiding this comment.
So, this file is generated by cabal2nix and any manual modifications to it will be blown away. I talked about it with the Haskell maintainers and they told me that the dangling reference is fine because it’s guarded by callPackage and the package is already marked as broken, and that it’s declaring something “true” about the package even if the thing it depends on is no longer, uh, there.
Getting rid of the dangling reference would require getting a PR into cabal2nix and it bumped as part of a haskell-updates cycle, which didn’t seem worth it to me for a broken package, so I didn’t. It would also mean that cabal2nix would handle it incorrectly on 24.05, where I think this package still actually works, I guess, but I don’t know if you’re expected to be able to use a new cabal2nix with an older Nixpkgs like that.
Anyway it seems wrong to touch this line and probably that should be reverted? Any manual modifications will get blown away by the next cabal2nix run, though.
I’m not really an expert in the Haskell machinery, I just had to touch it to get rid of dependencies. cc @maralorn
There was a problem hiding this comment.
Okay so I guess the problem is that opencv-extra got removed from the transitive-broken list in this PR, presumably because of an automatic cabal2nix thing, presumably because of something to do with me removing the overrides in #336110 or opencv3 getting removed. Beyond that I don’t know why it would happen.
There was a problem hiding this comment.
i didn't manually touch hackage-packages.nix i just modified the configuration file of the generator and regenerated, crucially i didn't touch broken.yaml. the problem is that opencv-extra wasn't there but only on the transitive broken file which is regenerated when you run the script.
There was a problem hiding this comment.
the regenerate-hackage-packages script has this in the documentation
Unless --fast is used, it will then use the generated nix expression by
running regenerate-transitive-broken-packages.sh which updates the transitive-broken.yaml
file. Then it re-runs hackage2nix.so exactly that, i have no idea why opencv-extra does not depend on any of the other opencv packages
There was a problem hiding this comment.
Sure I recognise that it's not your fault, rather you happened to be the first person touching haskell packages since the other PR. Still I don't think merging a PR that will break the base branch is the way to go here.
There was a problem hiding this comment.
So, opencv-extra does list opencv as a dependency in hackage-packages.nix. Is it… picking up the native library, instead of the Haskell package that it depends on? And somehow that’s different now to before my PRs and makes it no longer seem transitively broken to the machinery?
There was a problem hiding this comment.
Huh, I can look into this later today and fix it on haskell-updates. Then you can rebase and don't need to worry about this.
eldritch-cookie
force-pushed
the
fix-hls-in-ghc910
branch
from
f2d1b5c to
c4f8cd1
Compare
|
rebased, and everything seems fine |
ofborg
bot
added
10.rebuild-darwin: 0
ghc9101 is fully supported since haskell-language-server-2.9.0.0 https://github.com/haskell/haskell-language-server/pull/4319/files#diff-79cf716c1820425aff19ccc293f5526d96964620e8686a6da542d9c416474b7b Also ties loose end from NixOS#337720 (comment)
ghc9101 is fully supported since haskell-language-server-2.9.0.0 https://github.com/haskell/haskell-language-server/pull/4319/files#diff-79cf716c1820425aff19ccc293f5526d96964620e8686a6da542d9c416474b7b Also ties loose end from NixOS#337720 (comment)
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.