-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable haskell-language-server for ghc9101 #345945
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds instructions for using the prompt to longDescription
`nextflow` is no build by compiling from source instead of using the downloaded release file. This improves the overall accesibility (`version` will be shown on https://search.nixos.org/packages?query=nextflow) and allows to add & run tests more easily.
Co-authored-by: Nikolay Korotkiy <[email protected]>
The docker image hash seems to differ on different systems. See NixOS#339197 (comment)
The fixBinary flag will be enabled if a static emulator is in use.
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: phanirithvij <[email protected]>
ghc9101 is fully supported since haskell-language-server-2.9.0.0 https://github.com/haskell/haskell-language-server/pull/4319/files#diff-79cf716c1820425aff19ccc293f5526d96964620e8686a6da542d9c416474b7b Also ties loose end from NixOS#337720 (comment)
jmatsushita
requested review from
mmahut,
RaghavSood,
figsoda,
sternenseemann,
maralorn,
alyssais,
Ericson2314 and
infinisil
as code owners
October 2, 2024 14:48
github-actions
bot
added
6.topic: python
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: haskell
8.has: documentation
This PR adds or changes documentation
8.has: changelog
8.has: module (update)
This PR changes an existing module in `nixos/`
6.topic: vim
6.topic: erlang
6.topic: vscode
6.topic: lib
The Nixpkgs function library
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
labels
Oct 2, 2024
NixOSInfra
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Oct 2, 2024
Rebasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: erlang
6.topic: haskell
6.topic: lib
The Nixpkgs function library
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
6.topic: vim
6.topic: vscode
8.has: changelog
8.has: documentation
This PR adds or changes documentation
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
8.has: module (update)
This PR changes an existing module in `nixos/`
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ties loose end from #337720 (comment)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.