Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding info alert when new confirmation is from different origin or network #30550

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 25, 2025

Description

Adding info alert when new confirmation is from different origin or network

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4278

Manual testing steps

  1. Connect extension to multiple dapps
  2. Send confirmation request from first and then from second
  3. Notice info alerts on second confirmation

Screenshots/Recordings

Screenshot 2025-02-25 at 5 51 56 PM Screenshot 2025-02-25 at 5 41 36 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 25, 2025
@jpuri jpuri requested a review from a team as a code owner February 25, 2025 13:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0308d36]
Page Load Metrics (1722 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29919001570434208
domContentLoaded14941884169811053
load15021902172211655
domInteractive25104442110
backgroundConnect117532189
firstReactRender1677482512
getState516931
initialActions01000
loadScripts10501447126210349
setupStore86119189
uiStartup16762225196713565
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -231 Bytes (-0.00%)
  • common: 205 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants