Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes in network switched toast to include origin information also #30524

Closed
wants to merge 6 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 24, 2025

Description

Changes in network switched toast to include origin information also.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4278

Manual testing steps

  1. Connect to extension from 2 different DAPP and networks
  2. Submit confirmation from first followed by from second
  3. Check toast that appears

Screenshots/Recordings

Screenshot 2025-02-24 at 2 09 12 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 24, 2025
@jpuri jpuri requested review from a team as code owners February 24, 2025 08:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [29707e6]
Page Load Metrics (1625 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14281900163012861
domContentLoaded14161867159912560
load14391875162512560
domInteractive258737157
backgroundConnect126728167
firstReactRender1472372412
getState567232110
initialActions01000
loadScripts1033135111739244
setupStore76412126
uiStartup16342147185414067
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 92 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [e231a18]
Page Load Metrics (1705 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31719001561409196
domContentLoaded14651887166513866
load15111963170513867
domInteractive16215464521
backgroundConnect883432512
firstReactRender147429189
getState46014147
initialActions01000
loadScripts10691468123912962
setupStore877272411
uiStartup17222211195415072
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 92 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ee8453f]
Page Load Metrics (1702 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51821881637298143
domContentLoaded14472096165813665
load15012193170214972
domInteractive22164584622
backgroundConnect11117483014
firstReactRender1473312211
getState6112172411
initialActions01000
loadScripts10201690123114168
setupStore876202211
uiStartup17042481193616881
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 92 Bytes (0.00%)

@jpuri jpuri enabled auto-merge February 24, 2025 13:13
@metamaskbot
Copy link
Collaborator

Builds ready [24ef127]
Page Load Metrics (2026 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36023821945406195
domContentLoaded17302284199616981
load17362339202618287
domInteractive28132492613
backgroundConnect10106372813
firstReactRender1676402311
getState971302211
initialActions01000
loadScripts12061690146914670
setupStore96420199
uiStartup20112695232719895
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 92 Bytes (0.00%)

@jpuri jpuri marked this pull request as draft February 24, 2025 14:55
auto-merge was automatically disabled February 24, 2025 14:55

Pull request was converted to draft

@jpuri
Copy link
Contributor Author

jpuri commented Feb 25, 2025

closed in favor of #30550

@jpuri jpuri closed this Feb 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants