Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose extension ID to E2E tests #30539

Merged
merged 1 commit into from
Feb 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/e2e/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ function normalizeLocalNodeOptions(localNodeOptions) {
* @property {Bundler} bundlerServer - The bundler server.
* @property {mockttp.Mockttp} mockServer - The mock server.
* @property {object} manifestFlags - Flags to add to the manifest in order to change things at runtime.
* @property {string} extensionId - The extension ID (useful for connecting via `externally_connectable`).
*/

/**
Expand Down Expand Up @@ -144,6 +145,7 @@ async function withFixtures(options, testSuite) {

let webDriver;
let driver;
let extensionId;
let failed = false;

// ganacheServer variable to be deleted once all specs are migrated to anvil
Expand Down Expand Up @@ -266,6 +268,7 @@ async function withFixtures(options, testSuite) {

driver = (await buildWebDriver(driverOptions)).driver;
webDriver = driver.driver;
extensionId = driver.extensionId;

if (process.env.SELENIUM_BROWSER === 'chrome') {
await driver.checkBrowserForExceptions(ignoredConsoleErrors);
Expand Down Expand Up @@ -302,6 +305,7 @@ async function withFixtures(options, testSuite) {
localNodes,
mockedEndpoint,
mockServer,
extensionId,
});

const errorsAndExceptions = driver.summarizeErrorsAndExceptions();
Expand Down
Loading