Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose extension ID to E2E tests #30539

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 24, 2025

Description

The E2E test setup function (withFixtures) has been updated to pass the extension ID to E2E tests. This will be useful in the near future for testing the new multichain API, which is exposed over externally_connectable and requires the extension ID to use.

Open in GitHub Codespaces

Related issues

This was extracted from #27782

Manual testing steps

N/A, this isn't used yet so there is nothing to manually test.

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The E2E test setup function (`withFixtures`) has been updated to pass
the extension ID to E2E tests. This will be useful in the near future
for testing the new multichain API, which is exposed over
`externally_connectable` and requires the extension ID to use.

This was extracted from #27782
@metamaskbot
Copy link
Collaborator

Builds ready [2c6e608]
Page Load Metrics (1512 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13601964151514469
domContentLoaded13351883148913264
load13531907151213766
domInteractive21133412814
backgroundConnect85524168
firstReactRender1475352412
getState46314199
initialActions00000
loadScripts9531453108411756
setupStore76013147
uiStartup15092122171515775
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review February 24, 2025 23:31
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 25, 2025
@Gudahtt Gudahtt enabled auto-merge February 25, 2025 15:16
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gudahtt Gudahtt added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
@seaona seaona added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 9a9513b Feb 25, 2025
88 checks passed
@seaona seaona deleted the expose-extension-id-to-e2e-tests branch February 25, 2025 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 25, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team team-qa QA team team-wallet-api-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants