Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): Add transaction simulation supported networks global mock (#30507) #30527

Merged
merged 1 commit into from
Feb 24, 2025
+25 −14
Merged

fix (cherry-pick): Add transaction simulation supported networks global mock (#30507) #30527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions shared/constants/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,10 @@ export enum TokenStandard {
/** Not a token, but rather the base asset of the selected chain. */
none = 'NONE',
}

/**
* The hostname used for Ethereum Mainnet transaction simulations, and for
* retrieving metadata for transaction simulation supported networks.
*/
export const TX_SENTINEL_URL =
'https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io';
16 changes: 16 additions & 0 deletions test/e2e/mock-e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const {
SWAPS_API_V2_BASE_URL,
TOKEN_API_BASE_URL,
} = require('../../shared/constants/swaps');
const { TX_SENTINEL_URL } = require('../../shared/constants/transaction');
const { SECURITY_ALERTS_PROD_API_BASE_URL } = require('./tests/ppom/constants');
const {
DEFAULT_FEATURE_FLAGS_RESPONSE: BRIDGE_DEFAULT_FEATURE_FLAGS_RESPONSE,
Expand Down Expand Up @@ -314,6 +315,21 @@ async function setupMocking(
};
});

// This endpoint returns metadata for "transaction simulation" supported networks.
await server.forGet(`${TX_SENTINEL_URL}/networks`).thenJson(200, {
1: {
name: 'Mainnet',
group: 'ethereum',
chainID: 1,
nativeCurrency: { name: 'ETH', symbol: 'ETH', decimals: 18 },
network: 'ethereum-mainnet',
explorer: 'https://etherscan.io',
confirmations: true,
smartTransactions: true,
hidden: false,
},
});

await server
.forGet(`${SWAPS_API_V2_BASE_URL}/featureFlags`)
.thenCallback(() => {
Expand Down
16 changes: 2 additions & 14 deletions test/e2e/tests/simulation-details/simulation-details.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { hexToNumber } from '@metamask/utils';
import { Mockttp, MockttpServer } from 'mockttp';
import { CHAIN_IDS } from '../../../../shared/constants/network';
import { TX_SENTINEL_URL } from '../../../../shared/constants/transaction';
import FixtureBuilder from '../../fixture-builder';
import {
createDappTransaction,
Expand Down Expand Up @@ -43,15 +44,6 @@ import {
} from './mock-request-send-eth';
import { MockRequestResponse } from './types';

const TX_SENTINEL_URL =
'https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/';

const mockNetworkRequest = async (mockServer: Mockttp) => {
await mockServer.forGet(`${TX_SENTINEL_URL}/networks`).thenJson(200, {
'1': { name: 'Mainnet', confirmations: true },
});
};

async function withFixturesForSimulationDetails(
{
title,
Expand All @@ -64,17 +56,13 @@ async function withFixturesForSimulationDetails(
},
test: (args: Pick<Fixtures, 'driver' | 'mockServer'>) => Promise<void>,
) {
const testSpecificMock = async (mockServer: MockttpServer) => {
await mockNetworkRequest(mockServer);
await mockRequests(mockServer);
};
await withFixtures(
{
fixtures: new FixtureBuilder({ inputChainId })
.withPermissionControllerConnectedToTestDapp()
.build(),
title,
testSpecificMock,
testSpecificMock: mockRequests,
dapp: true,
localNodeOptions: {
hardfork: 'london',
Expand Down
Loading