Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): Add transaction simulation supported networks global mock (#30507) #30527

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 24, 2025

Cherry-picks ff041ab to v12.13.0.

Original PR description:

Description

A global mock has been added for the "supported networks" check made as part of the transaction simulations feature. This is triggered by certain types of confirmations (those that support transaction simulations), so it's triggered by a wide variety of E2E tests.

Open in GitHub Codespaces

Related issues

Fixes #30490

Manual testing steps

This should resolve the privacy snapshot related errors on CI.

You could also double-check that the mocked response is returned by running an e2e test locally that uses a confirmation that supports transaction simulation, then inspecting the network tab of the service worker dev console while the test is running, and checking the response to the
https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/networks call

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

A global mock has been added for the "supported networks" check made as
part of the transaction simulations feature. This is triggered by
certain types of confirmations (those that support transaction
simulations), so it's triggered by a wide variety of E2E tests.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30507?quickstart=1)

## **Related issues**

Fixes #30490

## **Manual testing steps**

This should resolve the privacy snapshot related errors on CI.

You could also double-check that the mocked response is returned by
running an e2e test locally that uses a confirmation that supports
transaction simulation, then inspecting the network tab of the service
worker dev console while the test is running, and checking the response
to the
`https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/networks` call

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: seaona <[email protected]>
@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 24, 2025
@danjm danjm merged commit 0ffc724 into Version-v12.13.0 Feb 24, 2025
66 of 67 checks passed
@danjm danjm deleted the cherr-pick-ff041ab-v12.13.0 branch February 24, 2025 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f175c78]
Page Load Metrics (1918 ± 163 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint150628041925345166
domContentLoaded149927581901335161
load151727841918339163
domInteractive23197574321
backgroundConnect104920136
firstReactRender1476342110
getState5100282713
initialActions01000
loadScripts104921171386281135
setupStore761252110
uiStartup169531992213387186

@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 24, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants