Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable account syncing #30464

Merged
merged 2 commits into from
Feb 20, 2025
+1 −2
Merged

feat: re-enable account syncing #30464

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddbc3e8
feat: re-enable account syncing
mathieuartu Feb 20, 2025
ca9b3c0
fix: remove isProduction import
mathieuartu Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/scripts/metamask-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
setEthAccounts,
addPermittedEthChainId,
} from '@metamask/multichain';
import { isProduction } from '../../shared/modules/environment';

Check failure on line 156 in app/scripts/metamask-controller.js

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

'isProduction' is defined but never used
import {
methodsRequiringNetworkSwitch,
methodsThatCanSwitchNetworkWithoutApproval,
Expand Down Expand Up @@ -1306,7 +1306,7 @@
},
},
env: {
isAccountSyncingEnabled: !isProduction() && isManifestV3,
isAccountSyncingEnabled: isManifestV3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a comment here maybe @mathieuartu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a "// Please do not disable"? 😬

I disagree, because in that case, we should add this to any other feature. I think it's on us to communicate more clearly internally that account syncing is here, is enabled, and is used by a lot of people.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we should probably don't expose this config variable anymore in the extension

},
messenger: this.controllerMessenger.getRestricted({
name: 'UserStorageController',
Expand Down
Loading