feat: re-enable account syncing

[mathieuartu]

Description

This PR re-enables account syncing.
This was disabled in this PR, but shouldn't have been.

Related issues

Fixes:

Manual testing steps

1. Import your SRP
2. Verify that your accounts are downloaded

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cmd-ob]

We should probably add a comment here maybe @mathieuartu.

[mathieuartu]

Like a "// Please do not disable"? 😬

I disagree, because in that case, we should add this to any other feature. I think it's on us to communicate more clearly internally that account syncing is here, is enabled, and is used by a lot of people.

[cmd-ob]

Agreed!

[mathieuartu]

Note: we should probably don't expose this config variable anymore in the extension

[metamaskbot]

Builds ready [ca9b3c0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1659 ± 119 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	370	2531	1604	376	181
		domContentLoaded	1395	2470	1636	241	116
		load	1404	2515	1659	249	119
		domInteractive	24	98	39	23	11
		backgroundConnect	8	60	22	16	8
		firstReactRender	14	79	37	25	12
		getState	4	52	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	972	1887	1198	210	101
		setupStore	7	56	11	11	5
		uiStartup	1578	2936	1917	293	140

Bundle size diffs [🚀 Bundle size reduced!]

• background: -155 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Missing release label release-12.13.0 on PR. Adding release label release-12.13.0 on PR and removing other release labels(release-12.14.0), as PR was cherry-picked in branch 12.13.0.