Skip to content
Main

feat: decouple push logic to be platform agnostic #14975

Sign in to view logs

feat: decouple push logic to be platform agnostic

feat: decouple push logic to be platform agnostic #14975

Triggered via pull request January 30, 2025 16:41
@Prithpal-SooriyaPrithpal-Sooriya
synchronize #5120
MMASSETS-493/decouple-push-logic-to-be-platform-agnostic
Status Success
Total duration 4m 47s
Artifacts –

main.yml

on: pull_request
Check workflows
8s
Check workflows
Matrix: Lint, build, and test / Prepare
Matrix: Lint, build, and test / Build
Matrix: Lint, build, and test / Lint
Matrix: Lint, build, and test / Test
Matrix: Lint, build, and test / Validate changelog
Determine whether this is a release merge commit
0s
Determine whether this is a release merge commit
All jobs complete
0s
All jobs complete
Publish release  /  publish-release
Publish release / publish-release
All jobs pass
0s
All jobs pass
Publish release  /  publish-npm-dry-run
Publish release / publish-npm-dry-run
Publish release  /  publish-npm
Publish release / publish-npm
Create update issues  /  create-update-issues
Create update issues / create-update-issues
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.test.ts#L5
`../../../packages/base-controller/tests/helpers` type import should occur after import of `./network-controller-types`
Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.ts#L196
Member '#gasPricesService' is never reassigned; mark it as `readonly`
Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-controller.ts#L241
Replace `·await·this.#gasPricesService.fetchGasPrices(⏎······chainId,⏎····` with `⏎······await·this.#gasPricesService.fetchGasPrices(chainId`
Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L41
Member '#fetch' is never reassigned; mark it as `readonly`
Lint, build, and test / Lint (20.x): examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L56
Missing JSDoc @returns declaration
Lint, build, and test / Lint (20.x): examples/example-controllers/src/pet-names-controller.test.ts#L8
`./pet-names-controller` type import should occur before type import of `../../../packages/base-controller/tests/helpers`
Lint, build, and test / Lint (20.x): examples/example-controllers/src/pet-names-controller.test.ts#L9
`./pet-names-controller` import should occur before type import of `../../../packages/base-controller/tests/helpers`
Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.test.ts#L23
No exported names found in module 'uuid'
Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.ts#L444
Expected 1 lines after block description
Lint, build, and test / Lint (20.x): packages/accounts-controller/src/AccountsController.ts#L546
Insert `⏎······`