feat: decouple push logic to be platform agnostic #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form agnostic this controller was ties to web, and was not compatible for react-native. We now have moves the logic that touches firebase and browser built-ins to an isolated file, and expect platforms to inject this into the controller This breaks the controller and forces the platform to inject how push notifications should be received and clicked
reduces complexity that the platform needs to write.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
commented
Jan 9, 2025
Prithpal-Sooriya
commented
Jan 9, 2025
...ices-controller/src/NotificationServicesPushController/NotificationServicesPushController.ts
Show resolved
Hide resolved
Prithpal-Sooriya
commented
Jan 9, 2025
...ion-services-controller/src/NotificationServicesPushController/__fixtures__/mockMessenger.ts
Show resolved
Hide resolved
Prithpal-Sooriya
commented
Jan 9, 2025
...notification-services-controller/src/NotificationServicesPushController/services/services.ts
Show resolved
Hide resolved
Prithpal-Sooriya
commented
Jan 9, 2025
.../notification-services-controller/src/NotificationServicesPushController/web/push-helpers.ts
Show resolved
Hide resolved
…ouple-push-logic-to-be-platform-agnostic
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…ouple-push-logic-to-be-platform-agnostic
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
force-pushed
the
MMASSETS-493/decouple-push-logic-to-be-platform-agnostic
branch
from
5689535 to
29ca3da
Compare
Prithpal-Sooriya
force-pushed
the
MMASSETS-493/decouple-push-logic-to-be-platform-agnostic
branch
from
29ca3da to
21576f2
Compare
…ouple-push-logic-to-be-platform-agnostic
…ouple-push-logic-to-be-platform-agnostic
…ouple-push-logic-to-be-platform-agnostic
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…ouple-push-logic-to-be-platform-agnostic
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
instead the push controller will bail early and do the correct checks
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…ouple-push-logic-to-be-platform-agnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Decouples web push notifications so that the controller is platform agnostic.
This controller was tied heavily to web, and was not compatible for mobile use (react-native). We have now isolated and moved the web specific code into a single file (
web/push-helpers.ts), and we expect the platforms to inject the push service interface into the controller (which allows platforms to controller how to display push notifications and click on push notifications).This is a large restructuring and is a breaking change.
References
Changelog
@metamask/notification-services-controllerPushServiceNotificationServicesPushControllerconfig property to inject aPushServiceinterface during controller creation.@metamask/notification-services-controller/push-services/webto help web platforms inject push-services into the push controller.Checklist