Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/tests: cache reference metrics | PoC w/ text #2382

Merged
merged 21 commits into from
Feb 26, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 14, 2024

What does this PR do?

it is a subset of #2335 with setting the CI and validation on Text only
with local runs, it seems to cut 40% times so for example BLUE score went from 2m32 to 1m24

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2382.org.readthedocs.build/en/2382/

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Feb 14, 2024
@Borda Borda changed the title ci: cache reference metrics | POC } text ci: cache reference metrics | POC w/ text Feb 14, 2024
@Borda
Copy link
Member Author

Borda commented Feb 15, 2024

@stancld is it possible that some metrics/references are not deterministic?
also it seem to be happening for metrics which has some list like arguments
cc: @SkafteNicki

FAILED unittests/text/test_mer.py::TestMatchErrorRate::test_mer_class[False-preds0-targets0] - AssertionError
FAILED unittests/text/test_mer.py::TestMatchErrorRate::test_mer_class[False-preds1-targets1] - AssertionError
FAILED unittests/text/test_wil.py::TestWordInfoLost::test_wil_class[False-preds1-targets1] - AssertionError
FAILED unittests/text/test_mer.py::TestMatchErrorRate::test_mer_functional[preds0-targets0] - AssertionError
FAILED unittests/text/test_wil.py::TestWordInfoLost::test_wil_functional[preds1-targets1] - AssertionError
FAILED unittests/text/test_mer.py::TestMatchErrorRate::test_mer_functional[preds1-targets1] - AssertionError
FAILED unittests/text/test_wip.py::TestWordInfoPreserved::test_wip_class[False-preds0-targets0] - AssertionError
FAILED unittests/text/test_wip.py::TestWordInfoPreserved::test_wip_class[False-preds1-targets1] - AssertionError
FAILED unittests/text/test_wip.py::TestWordInfoPreserved::test_wip_functional[preds0-targets0] - AssertionError
FAILED unittests/text/test_wip.py::TestWordInfoPreserved::test_wip_functional[preds1-targets1] - AssertionError

also when I run just the one test suite like wip it passes

@Borda Borda force-pushed the ci/cache-ref-text branch from 48c4e2d to 708615d Compare February 16, 2024 08:45
@Borda
Copy link
Member Author

Borda commented Feb 23, 2024

seems to be cache issue: python-cachier/cachier#196

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #2382 (184b392) into master (b548fad) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2382   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17352   17352           
======================================
  Hits        11961   11961           
  Misses       5391    5391           

@Borda Borda changed the title ci: cache reference metrics | POC w/ text CI/tests: cache reference metrics | PoC w/ text Feb 23, 2024
@mergify mergify bot added the ready label Feb 23, 2024
@Borda
Copy link
Member Author

Borda commented Feb 24, 2024

seems like unrelated GPU falling on GPU for timeout

FAILED unittests/image/test_fid.py::test_fid_same_input[768] - Failed: Timeout >240.0s
FAILED unittests/image/test_fid.py::test_fid_same_input[2048] - Failed: Timeout >240.0s
FAILED unittests/image/test_mifid.py::test_fid_same_input[2048] - Failed: Timeout >240.0s

@Borda
Copy link
Member Author

Borda commented Feb 26, 2024

Observed speed-up for standard unittests on GPU is 34min -> 18min

@Borda Borda merged commit 76f61a5 into master Feb 26, 2024
69 checks passed
@Borda Borda deleted the ci/cache-ref-text branch February 26, 2024 19:05
Borda added a commit that referenced this pull request Mar 16, 2024
* apply to text
* fix _PATH_ALL_TESTS
* _cache-references
* separate_files
* cachier master
* Apply suggestions from code review

(cherry picked from commit 76f61a5)
Borda added a commit that referenced this pull request Mar 18, 2024
* apply to text
* fix _PATH_ALL_TESTS
* _cache-references
* separate_files
* cachier master
* Apply suggestions from code review

(cherry picked from commit 76f61a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants