Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/tests: cache reference metrics | others/base #2407

Merged
merged 10 commits into from
Feb 27, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 26, 2024

What does this PR do?

it is a subset of #2335 and a follow-up of #2382

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2407.org.readthedocs.build/en/2407/

@Borda
Copy link
Member Author

Borda commented Feb 26, 2024

using fix from python-cachier/cachier#203
seems like install archive has the same dev version so it is not used :/
but tested it locally and seems to be fine

@Borda
Copy link
Member Author

Borda commented Feb 26, 2024

@SkafteNicki could you pls check why some inputs seems to return different values?

FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[mean-11-hp_filter0-preds0-target0] - AssertionError
FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[mean-11-hp_filter0-preds1-target1] - AssertionError
FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[none-8-hp_filter0-preds0-target0] - AssertionError
FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[none-8-hp_filter0-preds1-target1] - AssertionError
FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[none-11-hp_filter0-preds0-target0] - AssertionError
FAILED unittests/image/test_scc.py::TestSpatialCorrelationCoefficient::test_scc_functional[none-11-hp_filter0-preds1-target1] - AssertionError

or the inputs are not correctly hashed as different values? 😕

UPADTE: it seems the problem is the custom wrapper _wrapped_reference_scc while the cashier is not parsing/tracing it to the root function

@Borda Borda added the test / CI testing or CI label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #2407 (62d2bfe) into master (8740244) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2407   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17352   17352           
======================================
  Hits        11960   11960           
  Misses       5392    5392           

@Borda Borda merged commit 42eefbd into master Feb 27, 2024
64 of 68 checks passed
@Borda Borda deleted the ci/cache-ref-other branch February 27, 2024 08:25
@mergify mergify bot added the ready label Feb 27, 2024
Borda added a commit that referenced this pull request Mar 16, 2024
* apply to base
* cachier ==3.0.0
* --show_hidden
* fix wrapper

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 42eefbd)
Borda added a commit that referenced this pull request Mar 18, 2024
* apply to base
* cachier ==3.0.0
* --show_hidden
* fix wrapper

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 42eefbd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants