Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serviceMonitor) set 30s as default interval #941

Closed
wants to merge 1 commit into from

Conversation

dweber019
Copy link
Contributor

What this PR does / why we need it:

The default interval should be 30s to support the rate of 1m of the official Kong Grafana dashboard.
Dashboard https://grafana.com/grafana/dashboards/7424-kong-official/

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@dweber019 dweber019 requested a review from a team as a code owner November 13, 2023 12:01
the default interval should be 30s to support the rate of 1m of the official Kong Grafana dashboard
@dweber019 dweber019 force-pushed the fix/service-monitor-interval branch from 6f59017 to b377fed Compare November 13, 2023 12:01
Copy link
Contributor

@pangruoran pangruoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

Actually, if we don't set a default value, it will use 30 seconds by default.

https://github.com/prometheus-operator/prometheus-operator/blob/79502954f995929c8b3511d533a2e34bb3ee40ca/pkg/apis/monitoring/v1/prometheus_types.go#L224-L228

Have you encountered any issues before making this change?

@dweber019
Copy link
Contributor Author

Nice catch. We have indeed changed this in our Prometheus operator, so the issue was cased by our setup and not this chart or the Grafana dashboard.

Closing this PR. Thx

@dweber019 dweber019 closed this Nov 14, 2023
@dweber019 dweber019 deleted the fix/service-monitor-interval branch November 14, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants