Skip to content

Commit

Permalink
fix(serviceMonitor) set 30s as default interval
Browse files Browse the repository at this point in the history
the default interval should be 30s to support the rate of 1m of the official Kong Grafana dashboard
  • Loading branch information
dweber019 committed Nov 13, 2023
1 parent 663deb0 commit b377fed
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
7 changes: 7 additions & 0 deletions charts/kong/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## Unreleased

### Fixed

* The default interval should be 30s to support the rate of 1m of the official [Kong Grafana dashboard](https://grafana.com/grafana/dashboards/7424-kong-official/).
[#941](https://github.com/Kong/charts/pull/941)

## 2.31.0

### Improvements
Expand Down
4 changes: 4 additions & 0 deletions charts/kong/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ spec:
scheme: http
{{- if .Values.serviceMonitor.interval }}
interval: {{ .Values.serviceMonitor.interval }}
{{- else }}
interval: 30s
{{- end }}
{{- if .Values.serviceMonitor.honorLabels }}
honorLabels: true
Expand All @@ -29,6 +31,8 @@ spec:
scheme: http
{{- if .Values.serviceMonitor.interval }}
interval: {{ .Values.serviceMonitor.interval }}
{{- else }}
interval: 30s
{{- end }}
{{- if .Values.serviceMonitor.honorLabels }}
honorLabels: true
Expand Down

0 comments on commit b377fed

Please sign in to comment.