Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible cell assignments simpler #175

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

ekatsevi
Copy link
Member

@ekatsevi ekatsevi commented Jan 31, 2025

  • I added the optional logical argument remove_cells_w_zero_or_twoplus_grnas
    to run_qc(), which is relevant for low-MOI analyses with control_group = "nt_cells".
    If set to TRUE, then cells with zero or two or more gRNAs are removed from the analysis, as before.
    If set to FALSE, then cells with multiple gRNAs are kept in the analysis if
    they contain at most one targeting gRNA. For these cells, a perturbation identity
    can be unambiguously defined, and their inclusion increases the number of cells
    available for downstream analysis.
  • The data frames outputted by the calibration check, power check, and discovery
    analysis have two additional columns called n_trt and n_cntrl, giving the
    number of cells used in the treatment and control groups, respectively.
  • I have resolved the plotting bug described in this issue.
  • I have added a check in construct_cis_pairs() that grna_target_data_frame
    has columns chr, start, and end, resolving this issue.

@ekatsevi ekatsevi marked this pull request as ready for review January 31, 2025 22:04
@ekatsevi ekatsevi marked this pull request as draft January 31, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant