-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla score test #113
Open
ekatsevi
wants to merge
25
commits into
Katsevich-Lab:main
Choose a base branch
from
ekatsevi:score-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Vanilla score test #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalysis_functs_1.R
…to no_approximation if resampling_mechanism == asymptotic_normality
…c_normality option
…to no_approximation if resampling_mechanism == asymptotic_normality
…er than resampling_mechanism
…sis_parameters documentation
A few other notes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following new features:
set_analysis_parameters
calledresponse_regression_method
, which can take valuesapproximate_nb
(what we were doing previously) andnb
(a new option involving running an NB response regression). Theprint()
function now displays the response regression method.resampling_approximation
now has the optionstandard_normal
, which bypasses any resampling and instead compares the test statistic to N(0,1). Note that this option requiresresponse_regression_method = "nb"
. This functionality is accompanied by the test named"run_calibration_check with score test"
.resampling_mechanism = "crt"
is now available for ondisc-backed sceptre objects.