-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support quadratic constraints #181
Conversation
@tmigot We should probably add HS61, HS100 and HS219 in |
24709d4
to
b391a07
Compare
…OptNLPModel and MathOptNLSModel
If we replace |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 93.00% 86.94% -6.07%
==========================================
Files 4 5 +1
Lines 629 919 +290
==========================================
+ Hits 585 799 +214
- Misses 44 120 +76 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amontoison ! Thanks for the PR that's great.
I just had minor comments to add some tests.
How did you verify the result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amontoison ! It looks good to me.
I think we just need a problem in NLPModelsTest that has both quadratic and nonlinear constraints.
Let's go for 0.13.0 when you are ready.
c12dc0c
into
JuliaSmoothOptimizers:main
close #50
close #149
close #150
@tmigot You should be happy now 😃