Unsupported features should error, not warn

[odow]

@ccoffrin was running a few examples and getting incorrect results because quadratic constraints are not supported (#50).

Shouldn't this be an error instead of a warning?

NLPModelsJuMP.jl/src/utils.jl

Lines 216 to 219 in 12d8f23

	for (F, S) in contypes
	F == VI && continue
	F <: AF || @warn("Function $F is not supported.")
	S <: LS || @warn("Set $S is not supported.")

[ccoffrin]

I'll add to this a request for support of ScalarQuadraticFunction, which is maybe what #50 is about?

[amontoison]

Hi @odow and @ccoffrin,
I started to support quadratic constraints with #102.
I can find time to finalize it next week.

[amontoison]

Sorry for the delay @ccoffrin and @odow.
I finally added the support of quadratic constraints in #181.
We will return an error if we encounter an unsupported feature now.

Do you know where I can find an example of a JuMP model with a VectorQuadraticFunction ?

[odow]

A MOI.VectorQuadraticFunction is a vector of quadratic terms:

model = Model()
@variable(model, x[1:2])
@constraint(model, [x[1], x[1]^2 + x[1] * x[2] + 3.0] >= 0)

[amontoison]

Thanks Oscar, it will help to verify that my parser of MOI.VectorQuadraticFunction is working:
https://github.com/amontoison/NLPModelsJuMP.jl/blob/quadcon/src/utils.jl#L284-L345

[odow]

I didn't look at the details, but my only comment is that you might need a 2.0 or a 0.5 factor in there
https://github.com/amontoison/NLPModelsJuMP.jl/blob/0b227b47a2ad9c99b4c7c4f9efa569f421295532/src/utils.jl#L322
I don't know if your COO assumes symmetry, etc.

[amontoison]

We assume symmetry in this case, and add the 0.5 when we evaluate the constraints:
https://github.com/amontoison/NLPModelsJuMP.jl/blob/0b227b47a2ad9c99b4c7c4f9efa569f421295532/src/moi_nlp_model.jl#L114

[odow]

Cool cool. I think the definition of ScalarQuadraticFunction was a mistake. We should have just made it a list of terms. It's so easy to get confused with the different conventions.

[amontoison]

When we define a constraint with VectorQuadraticFunction, what are the accepted sets?
Is it MOI.NonPosivitive / MOI.NonNegative or MOI.Zeros, the sets allowed for VectorAffineFunction?
https://github.com/JuliaSmoothOptimizers/NLPModelsJuMP.jl/blob/main/test/nlp_problems/lincon.jl#L8

[odow]

what are the accepted sets

Any subtype of MOI.AbstractVectorSet. But yes, Nonnegative is f(x) >= 0, Nonpositive is f(x) <= 0, and Zeros is f(x) = 0.