Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Points of interest to use tiles #1979

Merged
merged 80 commits into from
Oct 31, 2024
Merged

Move Points of interest to use tiles #1979

merged 80 commits into from
Oct 31, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Mar 22, 2024

Fixes #1971

This change the following:

  1. It takes the POIs from a tile source and not from the server's database
  2. It downloads an offline file to allow seeing the POIs when offline - assuming we use the current offline model - i.e. only paying customers will have offline POIs
  3. Offline search is removed at this point in time
  4. When opening a POI it will try and take most of the information from OSM and overpass.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.02345% with 89 lines in your changes missing coverage. Please review.

Project coverage is 90.42%. Comparing base (ec5112d) to head (0746530).

Files with missing lines Patch % Lines
...Hiking.Web/src/application/services/poi.service.ts 75.64% 30 Missing and 8 partials ⚠️
...g.Web/src/application/services/wikidata.service.ts 3.03% 32 Missing ⚠️
...src/application/services/overpass-turbo.service.ts 6.25% 15 Missing ⚠️
...ng.Web/src/application/services/pmtiles.service.ts 0.00% 2 Missing ⚠️
...rc/application/services/search-results.provider.ts 75.00% 0 Missing and 1 partial ⚠️
...ng.Web/src/application/services/spatial.service.ts 98.11% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   90.75%   90.42%   -0.34%     
==========================================
  Files          95      100       +5     
  Lines        8242     8511     +269     
  Branches     1016     1074      +58     
==========================================
+ Hits         7480     7696     +216     
- Misses        537      585      +48     
- Partials      225      230       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IsraelHikingMap IsraelHikingMap deleted a comment from codecov bot Oct 26, 2024
@HarelM HarelM merged commit 16e8cfa into main Oct 31, 2024
6 of 7 checks passed
@HarelM HarelM deleted the tile-pois branch October 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted POI is not in database
3 participants