Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing images from wikidata and wikipedia #2081

Closed
2 tasks done
HarelM opened this issue Dec 2, 2024 · 3 comments · Fixed by #2083
Closed
2 tasks done

Missing images from wikidata and wikipedia #2081

HarelM opened this issue Dec 2, 2024 · 3 comments · Fixed by #2083
Assignees
Labels

Comments

@HarelM
Copy link
Member

HarelM commented Dec 2, 2024

What happened?

The following POI does not have a picture in IHM although it has a picture in both wikidata page and wikipedia page

What steps will reproduce the bug?

Suft to:
https://israelhiking.osm.org.il/poi/OSM/node_278478301

Take a loot at the image

What I expect to happen

To see at least the image from wikidata if not both from wikidata and wikipedia.

Platform

  • Israel Hiking Map app
  • Israel Hiking Map site in a browser

OS Name and Version

Any

Browser Name and Version

Any

Additional information

This is related to:

@HarelM HarelM added the bug label Dec 2, 2024
@YitzchakM
Copy link

Following...

@HarelM
Copy link
Member Author

HarelM commented Dec 8, 2024

The following place:
https://israelhiking.osm.org.il/poi/OSM/node_278474873
Has three images:
https://he.wikipedia.org/wiki/%D7%A7%D7%95%D7%91%D7%A5:IRAMOT-MENASHE01.JPG
https://commons.wikimedia.org//wiki/File:Spiseudsigt.jpg
https://en.wikipedia.org/wiki/File:RamotMenasheEntrance1997.jpg

The last file doesn't have an author or an attribution field, so it is not presented, but I don't see a reason not to present it.
This can be seen here:
https://en.wikipedia.org/w/api.php?action=query&prop=imageinfo&iiprop=extmetadata&format=json&origin=*&titles=File:RamotMenasheEntrance1997.jpg

@zstadler let me know if you can think of a good way to solve this.

The problem with בית עריף is that the link to the image is of type "File:..." and the site does not handle this well right now, but I have a relatively simple fix for that, which uncovered the above issue when I looked at other places.

@zstadler
Copy link
Member

zstadler commented Dec 9, 2024

IMO, we can show the third picture since it has a LicenseShortName: "Cc-by-sa-3.0" tag. The tricky part is the attribution, since the JSON info does not have an author name. This is also a problem for Wikipedia itself and they have solved it with this attribution:

image

I think it would be best to use the same wording as Wikipedia.

Following our phone discussion, I suggest we also check that the license is compatible:

  1. CC-* licenses without "NC"
  2. Public domain, such as this picture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants