-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add releases endpoint #65
base: main
Are you sure you want to change the base?
Conversation
APISpecification.yaml
Outdated
example: 2023-10-18 | ||
is_current: | ||
type: boolean | ||
example: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If the shape of release here is the same as the shape of release coming out of the
/releases
endpoint, then shouldn't line 444 just reference the release object on line 1076? - I am confused about the meaning of the
is_current
field here. It may mean:- that the release itself is current (i.e. latest integrated/partial), or
- that the genome/release combination is current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the shape of release here is the same as the shape of release coming out of the /releases endpoint, then shouldn't line 444 just reference the release object on line 1076?
Yes, you're right, thank you for pointing that out, I've done the changes
I am confused about the meaning of the is_current field here.
It's the one attached to a release, would you like me to call it somthing more explicit like release_is_current
?
@azangru as we agreed, this commit cad0c07 removes release FFR: We agreed to remove
|
Description
Add
/releases
endpoint which returns all the releases (for now)Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-2908
Example(s)
Request
Response
Dependencies
This PR needs to be merged and deployed first: Ensembl/ensembl-metadata-api#128