Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Ousman37 patch 1 #10096

Closed
wants to merge 16 commits into from
Closed

Ousman37 patch 1 #10096

Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7163177
data: Ousman37
Ousman37 Jan 3, 2024
7d2f3c3
Update data/Ousman37.json
SaraJaoude Jan 4, 2024
0622ca0
Update data/Ousman37.json
SaraJaoude Jan 4, 2024
087f128
Update data/Ousman37.json
SaraJaoude Jan 4, 2024
eac02eb
Update Ousman37.json
Ousman37 Jan 4, 2024
452504b
Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1
Ousman37 Jan 4, 2024
bfdd138
data: Ousman37
Ousman37 Jan 4, 2024
e45a643
Update data/Ousman37.json
SaraJaoude Jan 4, 2024
c1ffeac
Update data/Ousman37.json
SaraJaoude Jan 4, 2024
5592f70
data: Ousman37.json
Ousman37 Jan 5, 2024
7748cd2
Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1
Ousman37 Jan 5, 2024
006e0e9
Data: Ousman37
Ousman37 Jan 6, 2024
31788a9
Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1
Ousman37 Jan 6, 2024
8f9fb24
Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1
Ousman37 Jan 8, 2024
26a9227
Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1
Ousman37 Jan 17, 2024
03a6dc3
data: Ousman37.json
Ousman37 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 74 additions & 5 deletions data/Ousman37.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,86 @@
{
"name": "Ousman Ethmane",
"bio": "Passionate Front-End Developer | UI/UX Enthusiast | Building innovative web experiences",
"tags": [
"Open Source",
"HTML",
"CSS",
"JavaScript",
"React.js",
"Node.js",
"Git",
"GitHub",
"TypeScript"
],
"evenTags": [
"Front-End Development",
"UI/UX Design",
"Responsive Web Design",
"Version Control",
"Web Development Tools",
"Problem Solving",
"Debugging",
"Team Collaboration"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think if evenTags is a valid attribute, Please remove this from your json. You can add these tags to tags attribute if you want.

Suggested change
"evenTags": [
"Front-End Development",
"UI/UX Design",
"Responsive Web Design",
"Version Control",
"Web Development Tools",
"Problem Solving",
"Debugging",
"Team Collaboration"
],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated JSON structure: Removed 'evenTags' attribute and added tags to 'tags' attribute as suggested.

"socials": [
{
"name": "LinkedIn Follow me",
"url": "https://www.linkedin.com/in/ethmane-ousman-34885844/",
"icon": "fab fa-linkedin",
Copy link
Member

@SaraJaoude SaraJaoude Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a valid icon and I have made a suggestion as to what I believe you are looking to achieve:

Suggested change
"icon": "fab fa-linkedin",
"icon": "FaLinkedin",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SaraJaoude for your feedback and suggestion. I appreciate your input. I've made the necessary changes to use the custom icon format 'FaLinkedin' as you suggested. Please let me know if there are any further improvements or adjustments needed.

"color": "#0077B5"
},
{
"name": "GitHub Follow me",
"url": "https://github.com/Ousman37",
"icon": "fab fa-github",
"color": "#333"
},
{
"name": "Twitter Follow me",
"url": "https://twitter.com/Ethamne_dev",
"icon": "fab fa-twitter",
"color": "#1DA1F2"
}
],
"testimonials": [
{
"author": "John Doe",
"position": "CEO, XYZ Company",
"quote": "Ousman is an incredibly talented front-end developer. His work has greatly improved our website's user experience."
},
{
"author": "Jane Smith",
"position": "UI/UX Designer, ABC Agency",
"quote": "Working with Ousman has been a pleasure. He has a keen eye for design and pays great attention to detail."
}
],
Comment on lines +43 to +54
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 Jan 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be the right way to add testimonials & may not be displayed on your profile. Please check out these docs to know more about testimonials, and remove this from your json.

Suggested change
"testimonials": [
{
"author": "John Doe",
"position": "CEO, XYZ Company",
"quote": "Ousman is an incredibly talented front-end developer. His work has greatly improved our website's user experience."
},
{
"author": "Jane Smith",
"position": "UI/UX Designer, ABC Agency",
"quote": "Working with Ousman has been a pleasure. He has a keen eye for design and pays great attention to detail."
}
],

"links": [
{
"name": "Follow me on LinkedIn",
"group": "Socials Primary",
"name": "LinkedIn Follow me",
"url": "https://www.linkedin.com/in/ethmane-ousman-34885844/",
"icon": "FaLink"
"icon": "fab fa-linkedin",
"color": "#0077B5"
},
{
"name": "Follow me on GitHub",
"group": "Socials Primary",
"name": "GitHub Follow me",
"url": "https://github.com/Ousman37",
"icon": "FaGithub"
"icon": "fab fa-github",
"color": "#333"
},
{
"group": "Socials Primary",
"name": "Twitter Follow me",
"url": "https://twitter.com/Ethamne_dev",
"icon": "fab fa-twitter",
"color": "#1DA1F2"
}
]
],
"callToAction": {
"text": "Contact Me",
"url": "mailto:[email protected]"
}
Comment on lines +77 to +81
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callToAction doesn't seem to be a valid attribute. You can add mail url in the links array as a link.

Suggested change
],
"callToAction": {
"text": "Contact Me",
"url": "mailto:[email protected]"
}
]

}


Loading