Ousman37 patch 1 #10096

Ousman37 · 2024-01-04T21:06:01Z

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
All new and existing tests passed.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Co-authored-by: sital002 <[email protected]>

Corrected JSON: Fixed "Follow me on LinkedI" to "Follow me on LinkedIn" and quoted "FaLink" and "FaGithub".

Update Ousman Ethmane's Profile Information

coderabbitai · 2024-01-04T21:06:09Z

Important

Auto Review Skipped

Review was skipped due to path filters

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
- @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

data/Ousman37.json

SaraJaoude · 2024-01-04T21:41:24Z

data/Ousman37.json

+    {
+      "name": "LinkedIn Follow me",
+      "url": "https://www.linkedin.com/in/ethmane-ousman-34885844/",
+      "icon": "fab fa-linkedin",


This is not a valid icon and I have made a suggestion as to what I believe you are looking to achieve:

Suggested change

"icon": "fab fa-linkedin",

"icon": "FaLinkedin",

Thank you, @SaraJaoude for your feedback and suggestion. I appreciate your input. I've made the necessary changes to use the custom icon format 'FaLinkedin' as you suggested. Please let me know if there are any further improvements or adjustments needed.

SaraJaoude

You do not appear to have used valid icons - please see inline comment and update throughout.

You may wish to take a look at the Available Icons page in our Documentation.

Updated JSON data with correct icons.

kumarsonsoff3 · 2024-01-06T07:38:25Z

data/Ousman37.json

+  "evenTags": [
+    "Front-End Development",
+    "UI/UX Design",
+    "Responsive Web Design",
+    "Version Control",
+    "Web Development Tools",
+    "Problem Solving",
+    "Debugging",
+    "Team Collaboration"
+  ],


I don't think if evenTags is a valid attribute, Please remove this from your json. You can add these tags to tags attribute if you want.

Suggested change

"evenTags": [

"Front-End Development",

"UI/UX Design",

"Responsive Web Design",

"Version Control",

"Web Development Tools",

"Problem Solving",

"Debugging",

"Team Collaboration"

],

Updated JSON structure: Removed 'evenTags' attribute and added tags to 'tags' attribute as suggested.

kumarsonsoff3 · 2024-01-06T07:43:36Z

data/Ousman37.json

+  "testimonials": [
+    {
+      "author": "John Doe",
+      "position": "CEO, XYZ Company",
+      "quote": "Ousman is an incredibly talented front-end developer. His work has greatly improved our website's user experience."
+    },
+    {
+      "author": "Jane Smith",
+      "position": "UI/UX Designer, ABC Agency",
+      "quote": "Working with Ousman has been a pleasure. He has a keen eye for design and pays great attention to detail."
+    }
+  ],


It doesn't seem to be the right way to add testimonials & may not be displayed on your profile. Please check out these docs to know more about testimonials, and remove this from your json.

Suggested change

"testimonials": [

{

"author": "John Doe",

"position": "CEO, XYZ Company",

"quote": "Ousman is an incredibly talented front-end developer. His work has greatly improved our website's user experience."

},

{

"author": "Jane Smith",

"position": "UI/UX Designer, ABC Agency",

"quote": "Working with Ousman has been a pleasure. He has a keen eye for design and pays great attention to detail."

}

],

kumarsonsoff3 · 2024-01-06T07:47:53Z

data/Ousman37.json

+  ],
+  "callToAction": {
+    "text": "Contact Me",
+    "url": "mailto:[email protected]"
+  }


callToAction doesn't seem to be a valid attribute. You can add mail url in the links array as a link.

Suggested change

],

"callToAction": {

"text": "Contact Me",

"url": "mailto:[email protected]"

}

]

this has been addressed

chore: Remove 'evenTags' attribute and add tags to 'tags' attribute

Remove 'evenTags' and Update 'tags' in JSON - Eliminated invalid 'evenTags' attribute. - Merged its contents into the 'tags' attribute.

SaraJaoude · 2024-01-24T10:09:09Z

We look forward to seeing your Profile on BioDrop, but as there is no recent activity from you to make the changes suggested I am going to close this pull request.

We hope you will raise a new pull request to create your Profile and when you do, you might want to take a look at these Docs which will help with the suggested changes the maintainers have proposed.

Please remember you can also create your Profile using Forms.

Ousman37 and others added 7 commits January 3, 2024 17:59

data: Ousman37

7163177

Update data/Ousman37.json

7d2f3c3

Co-authored-by: sital002 <[email protected]>

Update data/Ousman37.json

0622ca0

Co-authored-by: sital002 <[email protected]>

Update data/Ousman37.json

087f128

Co-authored-by: sital002 <[email protected]>

Update Ousman37.json

eac02eb

Corrected JSON: Fixed "Follow me on LinkedI" to "Follow me on LinkedIn" and quoted "FaLink" and "FaGithub".

Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1

452504b

data: Ousman37

bfdd138

Update Ousman Ethmane's Profile Information

github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Jan 4, 2024

SaraJaoude reviewed Jan 4, 2024

View reviewed changes

data/Ousman37.json Outdated Show resolved Hide resolved

Update data/Ousman37.json

e45a643

SaraJaoude reviewed Jan 4, 2024

View reviewed changes

data/Ousman37.json Outdated Show resolved Hide resolved

Update data/Ousman37.json

c1ffeac

SaraJaoude reviewed Jan 4, 2024

View reviewed changes

SaraJaoude previously requested changes Jan 4, 2024

View reviewed changes

Ousman37 added 2 commits January 5, 2024 10:40

data: Ousman37.json

5592f70

Updated JSON data with correct icons.

Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1

7748cd2

kumarsonsoff3 suggested changes Jan 6, 2024

View reviewed changes

Ousman37 added 5 commits January 6, 2024 12:05

Data: Ousman37

006e0e9

chore: Remove 'evenTags' attribute and add tags to 'tags' attribute

Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1

31788a9

Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1

8f9fb24

Merge branch 'EddieHubCommunity:main' into Ousman37-patch-1

26a9227

data: Ousman37.json

03a6dc3

Remove 'evenTags' and Update 'tags' in JSON - Eliminated invalid 'evenTags' attribute. - Merged its contents into the 'tags' attribute.

SaraJaoude closed this Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ousman37 patch 1 #10096

Ousman37 patch 1 #10096

Ousman37 commented Jan 4, 2024

coderabbitai bot commented Jan 4, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

SaraJaoude Jan 4, 2024 •

edited

Loading

Ousman37 Jan 5, 2024

SaraJaoude left a comment

kumarsonsoff3 Jan 6, 2024

Ousman37 Jan 6, 2024

kumarsonsoff3 Jan 6, 2024 •

edited

Loading

kumarsonsoff3 Jan 6, 2024

SaraJaoude commented Jan 24, 2024

Ousman37 patch 1 #10096

Ousman37 patch 1 #10096

Conversation

Ousman37 commented Jan 4, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

coderabbitai bot commented Jan 4, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

SaraJaoude Jan 4, 2024 • edited Loading

Choose a reason for hiding this comment

Ousman37 Jan 5, 2024

Choose a reason for hiding this comment

SaraJaoude left a comment

Choose a reason for hiding this comment

kumarsonsoff3 Jan 6, 2024

Choose a reason for hiding this comment

Ousman37 Jan 6, 2024

Choose a reason for hiding this comment

kumarsonsoff3 Jan 6, 2024 • edited Loading

Choose a reason for hiding this comment

kumarsonsoff3 Jan 6, 2024

Choose a reason for hiding this comment

SaraJaoude commented Jan 24, 2024

CodeRabbit Configration File (`.coderabbit.yaml`)

SaraJaoude Jan 4, 2024 •

edited

Loading

kumarsonsoff3 Jan 6, 2024 •

edited

Loading