Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test New v. Legacy BTD in RigidInjection_BTD #3327

Merged
merged 7 commits into from
Sep 7, 2022
Merged

CI: Test New v. Legacy BTD in RigidInjection_BTD #3327

merged 7 commits into from
Sep 7, 2022

Conversation

EZoni
Copy link
Member

@EZoni EZoni commented Aug 19, 2022 •
edited
Loading

First step to add more CI coverage of the new BTD, see #3300. Follow up on the initial tests added in #1973.

Main changes:

  • We now compare particle positions and momenta between legacy BTD and new BTD (both plotfiles and openPMD).
  • The checksums are evaluated on the BTD plotfile data (so lab-frame data, instead of "regular" boosted-frame data).

To-do:

  • Add regular checksum analysis (on boosted-frame data)
  • If possible, move checksum analysis to back-transformed data
  • Compare more particle attributes between legacy and new BTD

@EZoni EZoni added component: tests Tests and CI component: diagnostics all types of outputs labels Aug 19, 2022
@EZoni EZoni force-pushed the rigid_injection_btd_test branch 3 times, most recently from 83699d3 to 3e62a47 Compare August 22, 2022 22:00
@EZoni EZoni force-pushed the rigid_injection_btd_test branch from 261f709 to 43ba4de Compare August 24, 2022 17:10
@EZoni EZoni force-pushed the rigid_injection_btd_test branch from 43ba4de to df35016 Compare August 24, 2022 17:22
@EZoni EZoni changed the title [WIP] Improve Testing of New v. Legacy BTD [WIP] CI: Test New v. Legacy BTD in RigidInjection_BTD Aug 24, 2022
@EZoni EZoni changed the title [WIP] CI: Test New v. Legacy BTD in RigidInjection_BTD CI: Test New v. Legacy BTD in RigidInjection_BTD Aug 24, 2022
RTSandberg
RTSandberg approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@RTSandberg RTSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edoardo!

Examples/Modules/RigidInjection/analysis_rigid_injection_BoostedFrame.py Outdated Show resolved Hide resolved
Examples/Modules/RigidInjection/analysis_rigid_injection_BoostedFrame.py Outdated Show resolved Hide resolved
@RemiLehe RemiLehe assigned RemiLehe and unassigned RemiLehe Aug 29, 2022
@ax3l ax3l assigned ax3l and RemiLehe and unassigned RemiLehe Aug 29, 2022
ax3l
ax3l approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much!

@ax3l ax3l merged commit 4d3914d into ECP-WarpX:development Sep 7, 2022
@EZoni EZoni mentioned this pull request Sep 8, 2022
Merged
2 tasks
lucafedeli88 pushed a commit to lucafedeli88/WarpX that referenced this pull request Sep 12, 2022
@EZoni @RTSandberg
@pre-commit-ci @lucafedeli88
CI: Test New v. Legacy BTD in RigidInjection_BTD (ECP-WarpX#3327)
d91cefe 
* Improve Testing of New v. Legacy BTD

* openPMD: Flush Series before Accessing Arrays

Co-authored-by: Ryan Sandberg <[email protected]>

* Add Checksums for RigidInjection_BTD (BTD data)

* Compare Also Particle Momenta (BTD data)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Sandberg <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Ryan Sandberg <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
dpgrote pushed a commit to dpgrote/WarpX that referenced this pull request Nov 22, 2022
@EZoni @RTSandberg
@pre-commit-ci @dpgrote
CI: Test New v. Legacy BTD in RigidInjection_BTD (ECP-WarpX#3327)
07cc990 
* Improve Testing of New v. Legacy BTD

* openPMD: Flush Series before Accessing Arrays

Co-authored-by: Ryan Sandberg <[email protected]>

* Add Checksums for RigidInjection_BTD (BTD data)

* Compare Also Particle Momenta (BTD data)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Sandberg <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Ryan Sandberg <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@EZoni EZoni deleted the rigid_injection_btd_test branch September 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTSandberg RTSandberg RTSandberg approved these changes

@ax3l ax3l ax3l approved these changes

@RevathiJambunathan RevathiJambunathan Awaiting requested review from RevathiJambunathan

Assignees

@ax3l ax3l

Labels
component: diagnostics all types of outputs component: tests Tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EZoni @ax3l @RTSandberg @RemiLehe