CI: Test New v. Legacy BTD in BTD_ReducedSliceDiag
#3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
added
component: tests
|
When I compare the legacy BTD output with the new BTD output in the Python analysis (see files changed in this PR), I get Ez arrays of different shapes:
Note that the new BTD array with plotfile and openPMD formats agree with each other up to machine precision, so that's consistent. I cannot yet compare those with the legacy array because of the mismatch in the shapes. Do you have any hints on where the snapshot = './lab_frame_data/snapshots/snapshot00003'
header = './lab_frame_data/snapshots/Header'
allrd, info = read_raw_data.read_lab_snapshot(snapshot, header)
Ez_legacy = allrd['Ez'] |
EZoni
changed the title
BTD_ReducedSliceDiagBTD_ReducedSliceDiag
EZoni
changed the title
BTD_ReducedSliceDiagBTD_ReducedSliceDiag
RTSandberg
approved these changes
Sep 16, 2022
EZoni
changed the title
BTD_ReducedSliceDiagBTD_ReducedSliceDiag
EZoni
changed the title
BTD_ReducedSliceDiagBTD_ReducedSliceDiag
RemiLehe
approved these changes
Sep 21, 2022
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 22, 2022
* CI: Test New BTD in `BTD_ReducedSliceDiag` * Compare Legacy BTD vs. New BTD * Fix Bug in Loading of openPMD Array Data * Fix CI Analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep adding more CI coverage of the new BTD, see #3300. Similar to #3327.
Main changes:
BTD_ReducedSliceDiag, evaluated on the BTD plotfile dataTo-do:
ionsspecies is not written to output (new BTD): clarified, see comments in BTD: Issue w/ Particle Output of Back-Transformed Diagnostics #3420.Note:
We cannot compare legacy BTD data with new BTD data (either plotfile or openPMD), because the array shapes are different (see comment below). As far as I understood from @RTSandberg, this is a known discrepancy and it is not expected to be taken care of any time soon.