Render HTML for summaries #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I explicitly disabled this for security concerns; I'd rather not encourage people putting html in their summaries either since it means third-party clients would also need to parse/render HTML which is a massive can of worms. Maybe markdown would be an acceptable in-between, but that still brings a burden of support on everyone.. Open to discussion tho |
|
Fair enough. Pixiv illustration summaries use html so I'm more motivated to push this haha There are some ways to address those issues, let's just put a pin in this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support HTML rendering features for displaying summaries, such as new lines, font styles, hyperlinks, etc. Should be backwards compatible with text rendering.
There are some security concerns, mainly if scripts are found in the summary. In case one archive points to metadata containing a malicious summary. I think how to resolve this is up for debate; whether to sanitize client-side or server-side or both. But I think this would be a better visual experience.
not too familiar with JS